[squeak-dev] The Trunk: Morphic-ct.1987.mcz

commits at source.squeak.org commits at source.squeak.org
Thu May 5 17:32:05 UTC 2022

Christoph Thiede uploaded a new version of Morphic to project The Trunk:

==================== Summary ====================

Name: Morphic-ct.1987
Author: ct
Time: 5 May 2022, 7:30:18.940075 pm
UUID: 1e487320-3cce-744c-ba97-b05cb11c9d99
Ancestors: Morphic-ct.1986, Morphic-ct.1959

Revises and merges Morphic-ct.1959 (clear emphasis when cancelling text morph edits).

Here is the correct bug report (original report was wrong):

	Do it:
		'plonk' edit.
	And then press <opt>7, <cmd>l into the editor.

Thanks to Marcel for the feedback!

=============== Diff against Morphic-ct.1986 ===============

Item was changed:
  ----- Method: PluggableTextMorph>>cancelSafely (in category 'menu commands') -----
  	"Cancel all edits by replacing the content with the original contents. Retain the undo history. The model can intervene via #okToRevertChanges, which is beneficial if all edits have already be communicated via #textEdited: so that the model can cancel its internal caches."
  	(model respondsTo: #okToRevertChanges:) ==> [model okToRevertChanges: editTextSelector]
  		ifFalse: [^ self].
  	self handleEdit: [
+ 		textMorph editor
+ 			clearEmphasisHere;
+ 			replaceAllWith: self getText.
- 		textMorph editor replaceAllWith: self getText.
  		self selectInterval: self getSelection.
  		self hasUnacceptedEdits: false.
  		self hasUserEdited: false].!

Item was added:
+ ----- Method: TextEditor>>clearEmphasisHere (in category 'typing support') -----
+ clearEmphasisHere
+ 	emphasisHere := #().!

More information about the Squeak-dev mailing list