[squeak-dev] The Trunk: ToolBuilder-Kernel-nice.159.mcz

commits at source.squeak.org commits at source.squeak.org
Fri May 6 14:53:20 UTC 2022

Nicolas Cellier uploaded a new version of ToolBuilder-Kernel to project The Trunk:

==================== Summary ====================

Name: ToolBuilder-Kernel-nice.159
Author: nice
Time: 6 May 2022, 4:53:19.127501 pm
UUID: dbbb7a90-f344-5e46-b97f-b26f5cbfba4c
Ancestors: ToolBuilder-Kernel-mt.158

Correct frenchism desarmHandler -> disarmHandler (companion to Kernel-ct.1406)

=============== Diff against ToolBuilder-Kernel-mt.158 ===============

Item was changed:
  ----- Method: ProgressInitiationException>>sendNotificationsTo: (in category 'handling') -----
  sendNotificationsTo: aNewBlock
  	"Resume execution using aNewBlock as workBlock value.
  	Note that the execution is resumed in signalContext (or outerContext).
  	This is done so that inner exception handlers be active during workBlock execution.
  	However, our own handlerContext should be deactivated, unless explicitely rearmed."
  	| mustDeactivateHandler |
  	mustDeactivateHandler := handlerContext notNil and: [handlerContext isHandlerActive not].
  			["The handlerContext is de-activated during handleSignal:
  			But it will be reactivated during unwinding when we will resumeEvaluating:
  			That's unwanted, we don't generally want to rearm the handler during workBlock evaluation.
  			Hence we have to deactivate it again inside the deferred block."
  			self resumeEvaluating:
  				[handlerContext deactivateHandler.
  				[workBlock value: [ :barVal |
  					aNewBlock value: minVal value: maxVal value: barVal]]
  						ensure: [handlerContext reactivateHandler]]]
  			["If the handler is active at this step, then it must have been rearmed
  			with a #rearmHandlerDuring:
  			It's thus intentional to keep the handler active during workBlock evaluation
+ 			But the ensure: [self disarmHandler] will be evaluated during unwinding when we will resumeEvaluating:
- 			But the ensure: [self desarmHandler] will be evaluated during unwinding when we will resumeEvaluating:
  			It is thus necessary to rearm again inside the evaluated block"
  			self resumeEvaluating:
  				[self rearmHandlerDuring:
  					[workBlock value: [ :barVal |
  						aNewBlock value: minVal value: maxVal value: barVal]]]]!

More information about the Squeak-dev mailing list