[squeak-dev] The Trunk: Multilingual-mt.285.mcz

commits at source.squeak.org commits at source.squeak.org
Tue May 10 09:22:28 UTC 2022

Marcel Taeumel uploaded a new version of Multilingual to project The Trunk:

==================== Summary ====================

Name: Multilingual-mt.285
Author: mt
Time: 10 May 2022, 11:22:26.243226 am
UUID: 5074865e-adc8-4a19-85e8-e9fae6d3ccfd
Ancestors: Multilingual-mt.284

Fixes regression in TextConverter #cleanUp: regarding that latin1Map optimization.

Thanks to Lauren (lrnp) for pointing that out!

=============== Diff against Multilingual-mt.284 ===============

Item was changed:
  ----- Method: TextConverter class>>cleanUp: (in category 'class initialization') -----
  cleanUp: aggressive
  	aggressive ifTrue: [
  		self allSubclassesDo: [:converterClass |
+ 			converterClass initializeTables.
+ 			converterClass allInstancesDo: [:converter |
+ 				self flag: #discuss. "mt: Ensure to update all instances to make the optimization work. See #installLineEndConvention: and #decodeString:."
+ 				(converter instVarNamed: #latin1Map) = "not == !!"converterClass latin1Map
+ 					ifTrue: [
+ 						converter instVarNamed: #latin1Map put: converterClass latin1Map "i.e., == !!".
+ 						converter instVarNamed: #latin1Encodings put: converterClass latin1Encodings "i.e., == !!"]]]].!
- 			converterClass initializeTables]].!

Item was changed:
+ (PackageInfo named: 'Multilingual') postscript: 'TextConverter cleanUp: true. "Fixes regression in #cleanUp:."'!
- (PackageInfo named: 'Multilingual') postscript: 'TextConverter cleanUp: true. "Initialize all uninitialized latin-1 tables... issue #6"'!

More information about the Squeak-dev mailing list