Hi all,


-0.5. :-)


No ultra-strong opinion here, but in general, comments are an inherent part of Smalltalk. As code and comments tell a shared story together, I'm not convinced by separating both from each other even more. Italic has a "virtual", "artificial", or "auxiliary" connotation to me, as opposed to "normal" or "real" code.


Regarding unterminated comments, which are rendered as italic indeed at the moment, I never found it intuitive that something becomes italic because you forget a missing quote. Maybe we could remove this emphasis as well. We also do not apply special emphasis to unterminated expressions with a missing closing bracket.


Best,

Christoph

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Montag, 16. Mai 2022 17:05:23
An: squeak-dev
Betreff: Re: [squeak-dev] Improving visibility of comments in Shout renders code within SqueakTheme

Hi Lauren, hi Dave, hi Tim --

Well, I am not strongly against this (anymore) since we fixed italic rendering at least for TrueType fonts.

I am leaning towards adding an "italic comments" preference as I like the current appearance... Hmm....

Note that the effect of an invalid Shout identifier would then not be so strong anymore. Red and italic are current indications of that.

Well, the "Community (dark)" theme does this already.

+/- 0 :-)

Best,
Marcel

Am 14.05.2022 16:44:59 schrieb David T. Lewis <lewis at mail.msen.com>:

Adding the italics to the comment font looks good to me also.

Dave

On Fri, May 13, 2022 at 04:02:21PM -0600, Lauren P wrote:
> Seconded.
>
> On Fri, May 13, 2022, 11:24 tim Rowledge wrote:
>
> > I find it very hard to discern the colour used by Shout for comments in
> > the SqueakTheme. I would like to suggest that we change to make it italic
> > as well as coloured.
> >
> > If we edit SqueakTheme class>>#addSyntaxHighlighting: where we set the
> > comment style -
> > set: #comment for: #SHTextStylerST80 to: {Color cyan
> > muchDarker. TextEmphasis italic};
> >
> > and then run `self create apply` in the browser then things are more
> > visible.
> >
> > tim
> > --
> > tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
> > Trancelators interpret messages from the dead
> >
> >
> >
> >

>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220516/b9f9d8e6/attachment.html>