Hi Christoph,

+1
It sounds reasonable to me. Try this:

Write

[420]

Select 420 and press ] to remove the brackets

Press CMD + z (undo)

and you get back [420] but this time the whole thing selected so you can’t remove the brackets by pressing ] because they’re inside the selection…

I’m just trying to show Christoph’s proposal doesn’t feel any more inconsistent than this behavior :)

Unless the above behavior is useful for something else :)

Best,


--

Jaromír Matas

mail at jaromir.net

From: christoph.thiede at student.hpi.uni-potsdam.de<mailto:christoph.thiede at student.hpi.uni-potsdam.de>
Sent: Friday, May 27, 2022 23:10
To: squeak-dev at lists.squeakfoundation.org<mailto:squeak-dev at lists.squeakfoundation.org>
Subject: Re: [squeak-dev] Merge Request: autoEncloseBeforeSpace.cs

Hi Jaromir, Marcel, all,

with Morphic-mt.1824 in current Trunk, we have the following behavior for closer brackets:

> Via "enclose selection" preference, an opening bracket adds a level and a closer bracket removes a level. No toggling anymore.

So pressing a closer bracket removes the pair of brackets that is *enclosing* the selection. However, I still wonder whether we should also remove the pair of brackets *inside* the selection if there is no further pair of brackets.

So that

    [123] (entire line selected)

when pressing

    ]

becomes

    123 (entire line selected)

instead of (as in current Trunk)

    ] (nothing selected)

Or would this be more inconsistent than convenient? Wdyt?

Best,
Christoph

---
Sent from Squeak Inbox Talk<https://github.com/hpi-swa-lab/squeak-inbox-talk>

On 2022-02-07T23:33:53+01:00, christoph.thiede at student.hpi.uni-potsdam.de wrote:

> Just a quick note to myself, compensating for the lack of meta information on the list:
> This issue has been resolved via Morphic-mt.1809. Thanks. :-)
>
> Best,
> Christoph
>
> ---
> Sent from Squeak Inbox Talk
>
> On 2021-11-01T22:09:46+01:00, christoph.thiede at student.hpi.uni-potsdam.de wrote:
>
> > Hi all!
> >
> > This changeset refines the existing autoEnclose mechanism. Instead of having inserted enclosing brackets always, you can now activate a new preference to only insert these characters if there is any space after the cursor. This matches VS Code's setting value "beforeWhitespace" for "editor.autoClosingBrackets".
> >
> > To me, this mode feels much more convenient because when having traditional autoEnclose enabled, I have been getting angry again and again when I wanted to bracketize an existing expression in some code and suddenly was disrupted by an unneeded closing bracket.
> >
> > The changeset does not manipulate any defaults. The PreferenceWizard and the ReleaseBuilder are updated, too. Please honor the postscript of the changeset when merging it.
> >
> > Best,
> > Christoph
> >
> > ---
> > Sent from Squeak Inbox Talk
> > -------------- next part --------------
> > An HTML attachment was scrubbed...
> > URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211101/4e337f68/attachment.html>
> > -------------- next part --------------
> > A non-text attachment was scrubbed...
> > Name: autoEncloseBeforeSpace.2.cs
> > Type: application/octet-stream
> > Size: 13012 bytes
> > Desc: not available
> > URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211101/4e337f68/attachment.obj>
> >
> >
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220207/34fe035a/attachment.html>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220527/7629975e/attachment.html>