[squeak-dev] The Trunk: Morphic-ct.2043.mcz

christoph.thiede at student.hpi.uni-potsdam.de christoph.thiede at student.hpi.uni-potsdam.de
Tue Sep 13 17:56:42 UTC 2022


Still, this approach feels flawed ... What is the idea behind checking #yellowButtonActivity: from Morph>>#yellowButtonActivity: at all? Can we come up with any better solution than this?

Best,
Christoph

---
Sent from Squeak Inbox Talk

On 2022-09-13T17:54:05+00:00, commits at source.squeak.org wrote:

> Christoph Thiede uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-ct.2043.mcz
> 
> ==================== Summary ====================
> 
> Name: Morphic-ct.2043
> Author: ct
> Time: 13 September 2022, 7:54:00.818738 pm
> UUID: e022b4f2-ce6b-584a-b084-1ce60b8cefeb
> Ancestors: Morphic-ct.2042
> 
> Fixes yellow-button menu invocation for pluggable lists that are not inside a system window. For instance, pluggable lists with in a dialog could not bring up their own menu previously but their containing dialog window's yellow-button menu was shown instead. See also Morphic-ct.1789.
> 
> =============== Diff against Morphic-ct.2042 ===============
> 
> Item was changed:
>   ----- Method: PluggableListMorph>>createListMorph (in category 'initialization') -----
>   createListMorph
>   
>       ^ self listMorphClass new
>           listSource: self;
>           cellInset: self class listMargins;
>           hResizing: #spaceFill;
>           vResizing: #shrinkWrap;
>           cellPositioning: #leftCenter;
>           setProperty: #indicateKeyboardFocus toValue: #never;
> +         wantsYellowButtonMenu: false;
>           yourself.!
> 
> Item was changed:
>   ----- Method: PluggableListMorph>>initialize (in category 'initialization') -----
>   initialize
>       listMorph := self createListMorph.
>       super initialize.
>       self scroller
>           layoutPolicy: TableLayout new;
> +         wantsYellowButtonMenu: false;
> +         addMorph: listMorph.
> -         addMorph: listMorph.    
>       self
>           minimumWidth: (self font widthOf: $m) * 5 ;
>           minimumHeight: self font height
>       
>       !
> 
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220913/a874dbc2/attachment.html>


More information about the Squeak-dev mailing list