[squeak-dev] The Trunk: Morphic-mt.2088.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Feb 1 09:50:39 UTC 2023

Marcel Taeumel uploaded a new version of Morphic to project The Trunk:

==================== Summary ====================

Name: Morphic-mt.2088
Author: mt
Time: 1 February 2023, 10:50:36.863309 am
UUID: bdece633-329a-554b-8704-cc4235bc4966
Ancestors: Morphic-mt.2087

Fixes visual glitch w/ filter background in multi-column lists.

=============== Diff against Morphic-mt.2087 ===============

Item was changed:
  ----- Method: LazyListMorph>>drawOn: (in category 'drawing') -----
  drawOn: aCanvas
  	| topRow bottomRow |
+ 	self backgroundColor ifNotNil: [:bgColor | | extra |
+ 		self owner ifNil: [extra := 0] ifNotNil: [:o |
+ 			extra := o boundsInWorld bottom - self boundsInWorld bottom max: 0].
+ 		aCanvas
+ 			fillRectangle: (self topLeft corner: self bottomRight + (0 at extra))
+ 			color: bgColor].
- 	self backgroundColor ifNotNil:
- 		[:bkgndColor |
- 		aCanvas fillRectangle: (self topLeft corner: self right @ ((self owner ifNil: [self]) bottom)) color: bkgndColor].
  	self getListSize = 0 ifTrue: [ ^self ].
  	self drawPreSelectionOn: aCanvas.
  	topRow := self topVisibleRowForCanvas: aCanvas.
  	bottomRow := self bottomVisibleRowForCanvas: aCanvas.
  	"Draw multi-selection."
  	self listSource hasMultiSelection ifTrue: 
  		[topRow to: bottomRow do:
  			[:row |
  			(self listSource itemSelectedAmongMultiple: row) ifTrue:
  				[self drawBackgroundForMulti: row on: aCanvas]]].
  	self drawSelectionOn: aCanvas.
  	"Draw hovered row if preference enabled."
  	PluggableListMorph highlightHoveredRow ifTrue:
  		[self listSource hoverRow > 0 ifTrue:
  			[self highlightHoverRow: listSource hoverRow on: aCanvas ]].
  	"Draw all visible rows."
  	topRow to: bottomRow do:
  		[:row |
  		self display: (self item: row) atRow: row on: aCanvas ].
  	"Finally, highlight drop row for drag/drop operations.."
  	self listSource potentialDropRow > 0 ifTrue:
  		[self highlightPotentialDropRow: self listSource potentialDropRow on: aCanvas ].!

More information about the Squeak-dev mailing list