[squeak-dev] PNGReadWriter buglet
tim Rowledge
tim at rowledge.org
Sat Feb 25 23:53:46 UTC 2023
> On 2023-02-25, at 3:46 PM, Vanessa Freudenberg <vanessa at codefrau.net> wrote:
>
> On further testing:
>
> up to 4.4: fine
> https://squeak.js.org/run/#zip=https://files.squeak.org/4.4/Squeak4.4-12327.zip
>
> since 4.5: broken
> https://squeak.js.org/run/#zip=https://files.squeak.org/4.5/Squeak4.5-13680.zip
>
> Filing 4.4's PNGReadWriter into 4.5 fixes the yellowing issue.
>
> Just filing in 4.4's PNGReadWriter>>copyPixelsRGB: also fixes the yellowing issue.
>
> Attaching ...
>
> (I realize this may be entirely unrelated to the issue you are seeing)
Weird that affects the yellow (R+G) channel but not the blue; and sadly, no it doesn't affect my problem despite being commented as related to color type 2.
An annoying thing here is that I had to look into this code several years ago and I have horrible memories bubbling up about how painful it all was. I really hope it isn't a change I made that is the problem...
tim
--
tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
"How many Kzin does it take to change a lightbulb?”
"None. You can scream and leap in the dark."
More information about the Squeak-dev
mailing list
|