Nice catch! Note that there is also "Project current transcript" ... not sure about the pros and cons of "Smalltalk at: #Transcript".


Best,

Christoph

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Montag, 9. Januar 2023 11:00:57
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: [squeak-dev] The Trunk: Morphic-mt.2057.mcz

Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.2057.mcz

==================== Summary ====================

Name: Morphic-mt.2057
Author: mt
Time: 9 January 2023, 11:00:54.890325 am
UUID: f093a34d-1306-2f44-89ca-f90c796f94c4
Ancestors: Morphic-ct.2056

Fixes two issues with Trascript:
1. "World Menu > Open... > transcript" should always count open transcripts
2. Menu item "Tools > Transcript" must not bind Transcript global but use Smalltalk>>#at: lookup.

The second bug occurred the moment we executed initialization code for new morphic projects to immediately render a preview thumbnail.

Note that I am still not in favor of executing code of a new project in the scope of the current project due to process management, globals, and other stuff. Let's keep an eye on this.

See
http://lists.squeakfoundation.org/pipermail/squeak-dev/2022-December/222795.html

I will backport this to Squeak 6.0.

=============== Diff against Morphic-ct.2056 ===============

Item was changed:
  ----- Method: TheWorldMainDockingBar>>transcriptMenuItemOn: (in category 'submenu - tools') -----
  transcriptMenuItemOn: menu

         menu addItem: [ :item |
                 item
                         contents: 'Transcript' translated;
                         help: 'Open the Transcript' translated;
                         icon: (self colorIcon: Transcript windowColorToUse);
+                        target: [ (Smalltalk at: #Transcript) open ];
+                        selector: #value ].!
-                        target: Transcript;
-                        selector: #open ]!

Item was changed:
  ----- Method: TheWorldMenu>>openTranscript (in category 'commands') -----
  openTranscript

+        Transcript open.!
-        Transcript openLabel: 'Transcript'!

Item was changed:
+ (PackageInfo named: 'Morphic') postscript: 'TheWorldMainDockingBar updateInstances. "Fix ''Tools > Transcript'' to make it late-bound."'!
- (PackageInfo named: 'Morphic') postscript: 'TheWorldMainDockingBar updateInstances. "Updates menu for Help > Contributing to Squeak"'!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20230109/de4cfd3e/attachment.html>