[squeak-dev] The Trunk: TrueType-tpr.99.mcz

Taeumel, Marcel Marcel.Taeumel at hpi.de
Mon Jan 16 08:39:24 UTC 2023


Hi Tim --

Thanks for doing this!

For the sake of readability, I would suggest replacing names like "filename" with "aFilename" and not "fname". In this case, even "each" would be better than "fname" because then you must re-read that previous "allFilenames" message to understand the code. "fname" could be "familyName" when ignoring the broader context. :-D

Best,
Marcel

Am 16.01.2023 03:16:15 schrieb commits at source.squeak.org <commits at source.squeak.org>:

tim Rowledge uploaded a new version of TrueType to project The Trunk:
http://source.squeak.org/trunk/TrueType-tpr.99.mcz

==================== Summary ====================

Name: TrueType-tpr.99
Author: tpr
Time: 15 January 2023, 6:16:03.619317 pm
UUID: 2d55d797-bbdb-4e2a-bf87-b73f0cfade1d
Ancestors: TrueType-mt.98

Remove some variable shadowing

=============== Diff against TrueType-mt.98 ===============

Item was changed:
----- Method: TTFontFileHandle>>printOn: (in category 'printing') -----
printOn: aStream

self parent ifNotNil: [:p | aStream nextPutAll: p fontname; nextPut: $ ].
aStream nextPutAll: self fontname.
self children notEmpty ifTrue: [aStream nextPut: $ ].
self children
do: [:subfont | aStream nextPutAll: subfont fontname]
separatedBy: [aStream nextPut: $/].
aStream nextPut: $ ; nextPut: $(.
self allFilenames
+ do: [:fname | aStream nextPutAll: fname]
- do: [:filename | aStream nextPutAll: filename]
separatedBy: [aStream nextPut: $,; nextPut: $ ].
aStream nextPut: $).
!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20230116/5a44beee/attachment.html>


More information about the Squeak-dev mailing list