New VMMaker/svn release

David T. Lewis lewis at mail.msen.com
Tue Jan 3 03:16:56 UTC 2006


On Mon, Jan 02, 2006 at 04:38:54PM -0800, tim Rowledge wrote:
> 
> On 2-Jan-06, at 3:23 PM, David T. Lewis wrote:
> >
> > Mea culpa. The sqGetFileNameFromString() function needs to null- 
> > terminate
> > the file name string after copying it, and I had not done that.
> >
> That would cause interesting problems, certainly.
> 
> > The new VMM/SVN works fine on Intel 32 bit Linux for both a 32 bit
> > and 64 bit VM. I'll check AMD-64 when I get a chance, but I don't
> > think there will be any problems there.
> >

I built VMs on AMD 64, no problems. All looks well for:

Intel 32 bit Linux 32 bit VM
Intel 32 bit Linux 64 bit VM
AMD 64 bit Linux 32 bit VM
AMD 64 bit Linux 64 bit VM

The previously mentioned patches still apply, including requirement
for inlined memory access functions rather than macros for 32 bit
VM on 64 bit AMD Linux.


> > The sqGetFileNameFromString() function I used is just this:
> >
> > sqInt sqGetFilenameFromString(char *aCharBuffer, char  
> > *aFilenameString, sqInt filenameLength, sqInt aBoolean)
> > {
> >   strncpy(aCharBuffer, aFilenameString, filenameLength);
> >   aCharBuffer[filenameLength] = 0;
> > }
> I think Ian had some quite extensive charset converting code attached  
> to the old macro? Ah, yes see sqUnixCharConv.c RISC OS uses the OS  
> call to canonicalize the path  and make sure it is fully qualified.


I'll have a look. Should have no effect on the VMM release, which
looks fine as near as I can tell.

Dave




More information about the Vm-dev mailing list