[FIX] lockSurfaces

Bert Freudenberg bert at impara.de
Fri Jul 7 08:08:26 UTC 2006

There is a wrong condition in an almost never-taken branch of  
BitBltSimulation>>lockSurfaces (when src=dst):

                 isWarping ifFalse:[
                     "When warping we always need the entire surface  
for the source"
                     sourceBits _ self cCode:'fn(sourceHandle,  
&sourcePitch, 0,0, sourceWidth, sourceHeight)'.
                 ] ifTrue:[
                     "Otherwise use overlapping area"
                     l _ sx min: dx. r _ (sx max: dx) + bbW.
                     t _ sy min: dy. b _ (sy max: sy) + bbH.
                     sourceBits _ self cCode:'fn(sourceHandle,  
&sourcePitch, l, t, r-l, b-t)'.

As the comments indicate, the condition is reversed. Please include  
attached fix in VMMaker.

- Bert -

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bltBltLockFix-bf.1.cs.gz
Type: application/x-gzip
Size: 1784 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20060707/bfd764fb/bltBltLockFix-bf.1.cs.bin
-------------- next part --------------

More information about the Vm-dev mailing list