Patch for FilePlugin - bug 3649

John M McIntosh johnmci at smalltalkconsulting.com
Thu May 18 19:17:45 UTC 2006


Does anyone know if this testcase works ok on the mac using the  
3.8.12 VM?

On 18-May-06, at 4:17 AM, Tony Garnock-Jones wrote:

> Hi Ian.
>
> I've found and fixed a problem in the Unix FilePlugin regarding
> directory deletion. The problem is already covered by a test case  
> in the
> 3.8 and 3.9 images. A description of the fault is here:
> http://bugs.impara.de/view.php?id=3649 and I've attached the patch
> against SVN trunk.
>
> Regards,
>   Tony
> Index: platforms/unix/plugins/FilePlugin/sqUnixFile.c
> ===================================================================
> --- platforms/unix/plugins/FilePlugin/sqUnixFile.c	(revision 1509)
> +++ platforms/unix/plugins/FilePlugin/sqUnixFile.c	(working copy)
> @@ -122,6 +122,12 @@
>      return false;
>    if (!sq2uxPath(pathString, pathStringLength, name, MAXPATHLEN, 1))
>      return false;
> +  if (lastPathValid && !strcmp(lastPath, name)) {
> +    closedir(openDir);
> +    lastPathValid = false;
> +    lastIndex = -1;
> +    lastPath[0] = '\0';
> +  }
>    return rmdir(name) == 0;
>  }
>

--
======================================================================== 
===
John M. McIntosh <johnmci at smalltalkconsulting.com> 1-800-477-2659
Corporate Smalltalk Consulting Ltd.  http://www.smalltalkconsulting.com
======================================================================== 
===




More information about the Vm-dev mailing list