[Vm-dev] Re: latest vmmaker wont run with pharo 1.1.1 (dev)

[Henrik Sperre Johansen]

On 07.11.2010 15:27, David T. Lewis wrote:
>
>>>> On Sat, Nov 6, 2010 at 8:21 PM, Esteban
>>>> Lorenzano<estebanlm at gmail.com>wrote:
>>>>
>>>>> I mean... 2hs and still not finished :(
>>>>>
>>>>>
>>>>> On 2010-11-06 20:18:59 -0300, Esteban Lorenzano<estebanlm at gmail.com>
>>>>> said:
>>>>>
>>>>>    mmm... now the "inlining step X" is taking for years... is that
>>>>>    normal?
>>>>>> Cheers,
>>>>>> Esteban
>>>>>>
>> On 07.11.2010 04:57, David T. Lewis wrote:
>>> No of course it is not normal, and as Eliot said you are probably stuck
>>> in a recursion for some reason or another. Use<alt>-period to interrupt
>>> and get a debugger to find out what went wrong.
>>>
> On Sun, Nov 07, 2010 at 11:32:04AM +0100, Henrik Sperre Johansen wrote:
>> IIRC, it's because in Pharo the method included in MiscPrimitivePlugin,
>> String>>#findSubstring..., is no longer the primitive, it's been moved
>> to findSubstringViaPrimitive...
>> findSubstring... now checks whether the primitive will work for the
>> parameters (WideStrings vs ByteStrings), before it actually calls the
>> primitive.
>> To "fix" this for Pharo, change the method included in
>> MiscPrimitivePlugin's "this is where my code should be located"-method.
>>
>> Cheers,
>> Henry
>>
>> PS. Most of these issues have been discussed here before, do a search of
>> the list and you are likely to find answers to speedbumps encountered
>> along the way.
>> Most notably, there's a MonticelloConfiguration which, as part of
>> loading VMMaker, will modify it/the image in the ways needed for it to
>> work on Pharo.
>>
> Thanks, that may well be the problem that Mariano is seeing. In addition
> to discussion on the list, it is also documented in the bug report that
> you opened in Mantis (thank you for doing this!):
>
>    http://bugs.squeak.org/view.php?id=7479
>
> I think that the proposed solution in Mantis 7479 is too fragile for
> my tastes.
Yeah, that's kind of the conclusion I came to as well :)

>   IMO the obvious solution is to fix the problem where it
> orginated, in the Pharo image.
Reverting would reintroduce getting invalid results from the plugin, 
without any workaround.
Not really an option.
>   If that cannot be accomplished, then
> someone might want to just reimplement the primitive as an ordinary
> primitive (but that is not something that I am working on).
>
> Dave
That's something I'd like to see as well.
My personal feeling after looking into it, is that while the 
plugins-with-source-in-image idea is neat, there are too many pitfalls 
(refactoring, reproducibility, etc.) for it to be a good idea overall.

Cheers,
Henry