[OT] Re: [Vm-dev] Re: [Pharo-project] Issue 3908 in pharo: Fix for pool variables references

[Igor Stasenko]

2011/3/30 Levente Uzonyi <leves at elte.hu>:
>
> On Wed, 30 Mar 2011, Igor Stasenko wrote:
>
>>
>> 2011/3/29 Levente Uzonyi <leves at elte.hu>:
>>>
>>> On Tue, 29 Mar 2011, Igor Stasenko wrote:
>>>
>>>>
>>>> 2011/3/29 Levente Uzonyi <leves at elte.hu>:
>>>>>
>>>>> On Tue, 29 Mar 2011, Igor Stasenko wrote:
>>>>>
>>>>>>
>>>>>> On 29 March 2011 17:44,  <pharo at googlecode.com> wrote:
>>>>>>>
>>>>>>> Updates:
>>>>>>>        Status: FixToInclude
>>>>>>>        Labels: Milestone-1.3 Importance-High
>>>>>>>
>>>>>>> Comment #1 on issue 3908 by siguc... at gmail.com: Fix for pool variables
>>>>>>> references
>>>>>>> http://code.google.com/p/pharo/issues/detail?id=3908
>>>>>>>
>>>>>>> (No comment was entered for this change.)
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> Finally i could navigate all uses of shared variables (class vars and
>>>>>> pool vars),
>>>>>> by simply pressing cmd-shift-n !
>>>>>> Its been years since i looked for that feature.. and fix was quite simple.
>>>>>
>>>>> Nice idea, wrong solution. ;)
>>>>>
>>>>
>>>> Have a time to elaborate?
>>>
>>> There's no guarantee, that model understands #selectedClassOrMetaClass, for example ObjectExplorer doesn't understand it.
>>>
>>>
>> In object explorer,
>> when i press shift-alt-n in lower pane, it works ok.
>
> Try this in Pharo (#13117):
>
> 1) 123 explore.
> 2) in the explorer's lower panel type Object
> 3) press Cmd+Shift+n
> 4) Enjoy the MNU
>
Yep. it not works.

>>
>> and when i click it in list, it producing DNU
>> Inspector>>browseClassRefs
>>
>> And in inspector, right and lower panes work ok, and top-left pane
>> producing same DNU.
>>
>> And yes, i was afraid that not all models will support that message,
>> and we discussed that.
>> And i got reassured by Benjamin that it does, because StringHolder
>> supports it :)
>>
>> Actually i am agree that model don't have to understand
>> #selectedClassOrMetaClass ,
>> but since it using SmalltalkEditor, then it should have some minimal
>> protocol, which SmalltalkEditor expects from model to support.
>> This may be something different, but idea should be the same: editor
>> should be able to ask model to provide an environment it currently
>> works in,
>> so then it could use #bindingOf: to determine if given symbolic name
>> has a binding in such environment.
>
> The idea is good, but it's just not there yet.
>

So, what you think is potential protocol for supporting this kind of lookups?
I don't like #selectedClassOrMetaClass selector either.

>>
>> So, it is a quick dirty hack, which works (in Pharo at least), and
>> gives us a way to quickly navigate over all uses of classvars or pool
>> vars.
>>
>> I intentionally posted this vm-dev list, because i was missing this
>> feature for too long when hacking VM.
>> Navigating over class vars in classes like Interpreter is pain.. and
>> there was no way to navigate over pool vars (and Eliot using them a
>> lot in Cog).
>
> I know. I added [OT] to the subject, because this discussion is about the implementation and not the feature itself.
>
>
> Levente
>
>>
>>
>>> Levente
>>>
>>
>>
>> --
>> Best regards,
>> Igor Stasenko AKA sig.
>
>



-- 
Best regards,
Igor Stasenko AKA sig.