[Vm-dev] Re: [squeak-dev] shift-enclose broken in trunk...

Guillermo Polito guillermopolito at gmail.com
Mon Apr 9 17:39:09 UTC 2012


On Mon, Apr 9, 2012 at 7:16 PM, Eliot Miranda <eliot.miranda at gmail.com>wrote:

>
>
> On Mon, Apr 9, 2012 at 4:04 AM, Bob Arning <arning315 at comcast.net> wrote:
>
>>  It works in 4.2 Mac for me. In 4.3, it fails as you reported.
>>
>
> So the change is then the discarding of shiftEncose: and its use
> in initializeShiftCmdKeyShortcuts.  This change was made when the signature
> for enclose: et al was changed to take KeyboardEvents as arguments instead
> of the characterStream made in Morphic-nice.566.  I agree with Nicholas'
> comment in Morphic-nice.566 that "#shiftEnclose: is hardcoding the keyboard
> layout, which is not compatible with foreign keyboards and modern VM, and
> prevents correct enclosing to work.".  Looks like there isn't enough
> information in a KeyboardEvent, e.g. the shifted and unshifted characters,
> for enclose: to do the right thing.  We need both the shifted and the
> unshifted character, and then enclose: can do the right thing.  But the VM
> does not pass up this information yet.
>
> I propose we modify the VMs asap to use the "reserved1" 7th field in a
> sqKeyboardEvent to contain the modified character as answered by the OS.
> For and against?
>

Maybe I'm not totally aware of the problem, but why do you need the
unshifted character?  The shortcut should get activated on one of the
enclosable characters ()[]{}<>, and that's all...

Guille


>
>

>
>>
>> Cheers,
>> Bob
>>
>>
>> On 4/8/12 3:46 PM, Eliot Miranda wrote:
>>
>> Hi All,
>>
>>       in the current 4.3 trunk shift-enclose on Mac doesn't work, it
>> performs the unshifted enclose.  e.g. command-shift-single-quote (which is
>> double quote) encloses with a single quote.  I think this is an image
>> issue.  It has been fine in my Qwaq/Teleplace image for ages, but in
>> testing I see it is broken in 4.2 also.  Anyone have any idea what's going
>> on here?
>> --
>> best,
>> Eliot
>>
>>
>>
>>
>>
>>
>>
>
>
> --
> best,
> Eliot
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20120409/4505f148/attachment-0001.htm


More information about the Vm-dev mailing list