[Vm-dev] [Cog] Cannot generate code anymore

Igor Stasenko siguctua at gmail.com
Sat Dec 22 00:24:53 UTC 2012


On 21 December 2012 22:09, Eliot Miranda <eliot.miranda at gmail.com> wrote:
>
> Igor,
>
>     quite so.  Perhaps I'll have time to change this soon.  SHouldn't be hard.  The test is straight-forward.  if after the change the system spits out unchanged source it is working :)
>
I can do it. Because i have a lot of pressure from Pharo team to fix VM...
i don't want to rollback last commit which broken our builds but
instead fix that stuff.

I will create a separate .cs so that you can easily merge it with your branch.

>
> On Wed, Dec 19, 2012 at 7:12 PM, Igor Stasenko <siguctua at gmail.com> wrote:
>>
>>
>> yeah.. just looked again at #buildCodeGeneratorForCogit: getAPIMethods
>>
>>
>>         cogitClasses := OrderedCollection new.
>>         [cogitClasses addFirst: cogitClass.
>>          cogitClass ~~ Cogit
>>          and: [cogitClass inheritsFrom: Cogit]] whileTrue:
>>                 [cogitClass := cogitClass superclass].
>>         cogitClasses addFirst: VMClass.
>>         cogitClasses addAllLast: self cogitClass ancilliaryClasses.
>>         cogitClasses do: [:cgc| cg addClass: cgc].
>>         (cg structClassesForTranslationClasses: cogitClasses) do:
>>                 [:structClass| cg addStructClass: structClass].
>>
>> see what wrong there?
>>
>> it letting vmmaker to decide for a class what to do, instead letting
>> class to decide for itself.
>> This logic is clearly do not belongs to right place.
>
>
>
>
> --
> best,
> Eliot
>



-- 
Best regards,
Igor Stasenko.


More information about the Vm-dev mailing list