[Vm-dev] [Cog] Cannot generate code anymore

[Eliot Miranda]

On Fri, Dec 21, 2012 at 4:24 PM, Igor Stasenko <siguctua at gmail.com> wrote:

>
> On 21 December 2012 22:09, Eliot Miranda <eliot.miranda at gmail.com> wrote:
> >
> > Igor,
> >
> >     quite so.  Perhaps I'll have time to change this soon.  SHouldn't be
> hard.  The test is straight-forward.  if after the change the system spits
> out unchanged source it is working :)
> >
> I can do it. Because i have a lot of pressure from Pharo team to fix VM...
> i don't want to rollback last commit which broken our builds but
> instead fix that stuff.
>
> I will create a separate .cs so that you can easily merge it with your
> branch.
>

thanks!!  Happy Holidays...


>
> >
> > On Wed, Dec 19, 2012 at 7:12 PM, Igor Stasenko <siguctua at gmail.com>
> wrote:
> >>
> >>
> >> yeah.. just looked again at #buildCodeGeneratorForCogit: getAPIMethods
> >>
> >>
> >>         cogitClasses := OrderedCollection new.
> >>         [cogitClasses addFirst: cogitClass.
> >>          cogitClass ~~ Cogit
> >>          and: [cogitClass inheritsFrom: Cogit]] whileTrue:
> >>                 [cogitClass := cogitClass superclass].
> >>         cogitClasses addFirst: VMClass.
> >>         cogitClasses addAllLast: self cogitClass ancilliaryClasses.
> >>         cogitClasses do: [:cgc| cg addClass: cgc].
> >>         (cg structClassesForTranslationClasses: cogitClasses) do:
> >>                 [:structClass| cg addStructClass: structClass].
> >>
> >> see what wrong there?
> >>
> >> it letting vmmaker to decide for a class what to do, instead letting
> >> class to decide for itself.
> >> This logic is clearly do not belongs to right place.
> >
> >
> >
> >
> > --
> > best,
> > Eliot
> >
>
>
>
> --
> Best regards,
> Igor Stasenko.
>



-- 
best,
Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20121221/ce5b1cd2/attachment.htm