[Vm-dev] Fwd: squeak-vm-4.10.2.2614 bug report

[Eliot Miranda]

tis in lockSurfaces:


"Otherwise use overlapping area"
l := sx min: dx. r := (sx max: dx) + bbW.
t := sy min: dy. b := (sy max: sy) + bbH.
sourceBits := self cCode:'fn(sourceHandle, &sourcePitch, l, t, r-l, b-t)'.

I'll change it to

"Otherwise use overlapping area"
l := sx min: dx. r := (sx max: dx) + bbW.
t := sy min: dy. b := (sy max: dy) + bbH.
sourceBits := self cCode:'fn(sourceHandle, &sourcePitch, l, t, r-l, b-t)'.


On Tue, Dec 10, 2013 at 10:48 AM, Ian Piumarta <piumarta at speakeasy.net>wrote:

>
> FYI.  This looks like a case of "x min: x" or "x max: x" somewhere in
> BitBlt.
>
> Begin forwarded message:
>
> > Date: December 10, 2013 08:35:49 PST
> > Subject: squeak-vm-4.10.2.2614 bug report
> >
> > Hello there,
> >
> > I just ran  the static analyser cppcheck over the source
> > code of squeak-vm-4.10.2.2614. It said many things,
> > including
> >
> >
> [/home/dcb/rpmbuild/BUILD/Squeak-4.10.2.2614-src-no-mp3/unix/src/vm/intplugins/BitBltPlugin/BitBltPlugin.c:2573]
> ->
> [/home/dcb/rpmbuild/BUILD/Squeak-4.10.2.2614-src-no-mp3/unix/src/vm/intplugins/BitBltPlugin/BitBltPlugin.c:2573]:
> (style) Same expression on both sides of '<'.
> >
> > Source code is
> >
> >                    b = (((sy < sy) ? sy : sy)) + bbH;
> >
> > Regards
> >
> > David Binderman
>
>


-- 
best,
Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20131210/f5a9dc59/attachment.htm