[Vm-dev] Fwd: squeak-vm-4.10.2.2614 bug report

David T. Lewis lewis at mail.msen.com
Wed Dec 11 13:32:35 UTC 2013


On Tue, Dec 10, 2013 at 10:59:44AM -0800, Eliot Miranda wrote:
>  
> The attached will be in the Cog branch.  Cam someone put it in VMMaker?
> 

Done. Thanks Eliot.

Ian, sources are updated in trunk/src

Dave


> 
> On Tue, Dec 10, 2013 at 10:58 AM, Eliot Miranda <eliot.miranda at gmail.com>wrote:
> 
> > tis in lockSurfaces:
> >
> >
> > "Otherwise use overlapping area"
> > l := sx min: dx. r := (sx max: dx) + bbW.
> >  t := sy min: dy. b := (sy max: sy) + bbH.
> > sourceBits := self cCode:'fn(sourceHandle, &sourcePitch, l, t, r-l, b-t)'.
> >
> > I'll change it to
> >
> > "Otherwise use overlapping area"
> > l := sx min: dx. r := (sx max: dx) + bbW.
> >  t := sy min: dy. b := (sy max: dy) + bbH.
> > sourceBits := self cCode:'fn(sourceHandle, &sourcePitch, l, t, r-l, b-t)'.
> >
> >
> > On Tue, Dec 10, 2013 at 10:48 AM, Ian Piumarta <piumarta at speakeasy.net>wrote:
> >
> >>
> >> FYI.  This looks like a case of "x min: x" or "x max: x" somewhere in
> >> BitBlt.
> >>
> >> Begin forwarded message:
> >>
> >> > Date: December 10, 2013 08:35:49 PST
> >> > Subject: squeak-vm-4.10.2.2614 bug report
> >> >
> >> > Hello there,
> >> >
> >> > I just ran  the static analyser cppcheck over the source
> >> > code of squeak-vm-4.10.2.2614. It said many things,
> >> > including
> >> >
> >> >
> >> [/home/dcb/rpmbuild/BUILD/Squeak-4.10.2.2614-src-no-mp3/unix/src/vm/intplugins/BitBltPlugin/BitBltPlugin.c:2573]
> >> ->
> >> [/home/dcb/rpmbuild/BUILD/Squeak-4.10.2.2614-src-no-mp3/unix/src/vm/intplugins/BitBltPlugin/BitBltPlugin.c:2573]:
> >> (style) Same expression on both sides of '<'.
> >> >
> >> > Source code is
> >> >
> >> >                    b = (((sy < sy) ? sy : sy)) + bbH;
> >> >
> >> > Regards
> >> >
> >> > David Binderman
> >>
> >>
> >
> >
> > --
> > best,
> > Eliot
> >
> 
> 
> 
> -- 
> best,
> Eliot




More information about the Vm-dev mailing list