[Vm-dev] [squeak-dev] VM 4.4 build nastinesses - part 1 of probably many

[Eliot Miranda]

On Wed, Feb 13, 2013 at 2:19 PM, tim Rowledge <tim at rowledge.org> wrote:
>
>
>
> On 13-02-2013, at 2:12 PM, tim Rowledge <tim at rowledge.org> wrote:
>
> > Aaaannnd on to FilePlugin.
> >
> > The new bit for sqFileStdioHandlesInto(SQFile files[3]) makes my head hurt reading the declaration (cdecl.org appears not to like the sanitised-as-best-I-can int foo( int bar[3]) either) but the bit my compiler is annoyed about is the call by using
> > sqFileStdioHandlesInto(& filesRecords)
> > It doesn't mind
> > sqFileStdioHandlesInto(fileRecords)  - which does seem a bit less weird to me but who knows.
> >
> > Surely if one were using &foo the cdecl ought to be foo(SQFile * bar) ?


In my code base I never use &fileRecords, only fileRecords.  Where's
the sqFileStdioHandlesInto(& filesRecords) call?  IMO it's wrong.

>
>
> OOps, bad choice of meaningless placeholder names there.
>
> Surely if one were using &fileRecords the cdecl ought to be foo(SQFile * bar) ?
>
> tim
> --
> tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
> Strange OpCodes: RLB: Ruin Logic Board
>
>



--
best,
Eliot