[Vm-dev] VM Maker: VMMaker-dtl.298.mcz

Bert Freudenberg bert at freudenbergs.de
Thu Feb 14 11:36:31 UTC 2013


On 2013-02-14, at 02:18, "David T. Lewis" <lewis at mail.msen.com> wrote:

> 
> On Wed, Feb 13, 2013 at 06:56:26PM +0100, Bert Freudenberg wrote:
>> 
>> On 2013-02-13, at 00:34, commits at source.squeak.org wrote:
>> 
>>> VMMaker 4.10.11
>>> 
>>> Enable large cursor support in the 64-bit image. Previous concern about bitmap conversion is apparently no longer relevant, as #primitiveBeCursor works properly on the 64-bit image (but tested only on little-endian).
>>> 
>>> =============== Diff against VMMaker-dtl.297 ===============
>>> 
>>> Item was changed:
>>> ----- Method: InterpreterPrimitives>>primitiveBeCursor (in category 'I/O primitives') -----
>>> primitiveBeCursor
>>> 	"Set the cursor to the given shape. The Mac only supports 16x16 pixel cursors. Cursor offsets are handled by Smalltalk."
>>> 
>>> 	| cursorObj maskBitsIndex maskObj bitsObj extentX extentY depth offsetObj offsetX offsetY cursorBitsIndex ourCursor |
>>> 
>>> - self flag: #Dan.  "This is disabled until we convert bitmaps appropriately"
>>> - objectMemory bytesPerWord = 8 ifTrue: [^ self pop: argumentCount].
>>> - 
>> 
>> This primitive is not only for ARGB cursors but for all cursor changes. You should try with something like 
>> 
>> 	Cursor crossHair showWhile: [Sensor waitButton]
>> 
>> to see if regular (1 / 2 bit) cursors work, too.
>> 
> 
> Thanks Bert,
> 
> The crossHair cursor seems to work fine on the 64-bit image also. I'm not
> sure what else might need testing, but it just looked to me like a leftover
> thing that Dan had meant to come back to. I can't say what the original
> issue may have been, but I see no indication of a problem now, so the code
> that Dan put in to disable it for 64-bit images is gone now, along with
> the 'self flag: #Dan' marker.


The original intention was to convert bitmaps to use 64-bit words. In that case the cursor layout would have been wrong.

Since that didn't happen yet, the code assuming 32-bit words just works, apparently.

- Bert -




More information about the Vm-dev mailing list