[Vm-dev] [commit][2743] Cog VM source as per VMMaker.oscog-eem.278.mcz.

commits at squeakvm.org commits at squeakvm.org
Fri Jun 14 23:51:37 UTC 2013


Revision: 2743
Author:   eliot
Date:     2013-06-14 16:51:36 -0700 (Fri, 14 Jun 2013)
Log Message:
-----------
Cog VM source as per VMMaker.oscog-eem.278.mcz.

Fix bad performance regression that on certain platforms (linux) results in all
send misses causing a discarded PIC creation followed by a slow hash lookup.

Modified Paths:
--------------
    branches/Cog/nscogsrc/vm/cogit.c
    branches/Cog/nscogsrc/vm/cogit.h
    branches/Cog/nscogsrc/vm/cogmethod.h
    branches/Cog/src/vm/cogit.c
    branches/Cog/src/vm/cogit.h
    branches/Cog/src/vm/cogmethod.h

Property Changed:
----------------
    branches/Cog/platforms/Cross/vm/sqSCCSVersion.h

Modified: branches/Cog/nscogsrc/vm/cogit.c
===================================================================
--- branches/Cog/nscogsrc/vm/cogit.c	2013-06-12 21:59:13 UTC (rev 2742)
+++ branches/Cog/nscogsrc/vm/cogit.c	2013-06-14 23:51:36 UTC (rev 2743)
@@ -1,9 +1,9 @@
 /* Automatically generated by
-	CCodeGenerator VMMaker.oscog-eem.282 uuid: 6c2f2048-555b-4d37-a9eb-4d9252acf3b9
+	CCodeGenerator VMMaker.oscog-eem.299 uuid: e51057f5-4de2-4c2b-82ce-844d130e2f33
    from
-	StackToRegisterMappingCogit VMMaker.oscog-eem.282 uuid: 6c2f2048-555b-4d37-a9eb-4d9252acf3b9
+	StackToRegisterMappingCogit VMMaker.oscog-eem.299 uuid: e51057f5-4de2-4c2b-82ce-844d130e2f33
  */
-static char __buildInfo[] = "StackToRegisterMappingCogit VMMaker.oscog-eem.282 uuid: 6c2f2048-555b-4d37-a9eb-4d9252acf3b9 " __DATE__ ;
+static char __buildInfo[] = "StackToRegisterMappingCogit VMMaker.oscog-eem.299 uuid: e51057f5-4de2-4c2b-82ce-844d130e2f33 " __DATE__ ;
 char *__cogitBuildInfo = __buildInfo;
 
 
@@ -2827,7 +2827,7 @@
 		/* otherwise attempt to create a closed PIC for the two cases. */
 
 		pic = cogPICSelectornumArgsCase0MethodCase1MethodtagisMNUCase((targetMethod->selector), (targetMethod->cmNumArgs), targetMethod, newTargetMethodOrNil, cacheTag, errorSelectorOrNil == SelectorDoesNotUnderstand);
-		if ((((sqInt)pic)) < 0) {
+		if ((((((sqInt)pic)) >= MaxNegativeErrorCode) && ((((sqInt)pic)) <= -1))) {
 
 			/* For some reason the PIC couldn't be generated, most likely a lack of code memory.
 			   Continue as if this is an unlinked send. */

Modified: branches/Cog/nscogsrc/vm/cogit.h
===================================================================
--- branches/Cog/nscogsrc/vm/cogit.h	2013-06-12 21:59:13 UTC (rev 2742)
+++ branches/Cog/nscogsrc/vm/cogit.h	2013-06-14 23:51:36 UTC (rev 2743)
@@ -1,5 +1,5 @@
 /* Automatically generated by
-	CCodeGenerator VMMaker.oscog-eem.282 uuid: 6c2f2048-555b-4d37-a9eb-4d9252acf3b9
+	CCodeGenerator VMMaker.oscog-eem.299 uuid: e51057f5-4de2-4c2b-82ce-844d130e2f33
  */
 
 

Modified: branches/Cog/nscogsrc/vm/cogmethod.h
===================================================================
--- branches/Cog/nscogsrc/vm/cogmethod.h	2013-06-12 21:59:13 UTC (rev 2742)
+++ branches/Cog/nscogsrc/vm/cogmethod.h	2013-06-14 23:51:36 UTC (rev 2743)
@@ -1,5 +1,5 @@
 /* Automatically generated by
-	CCodeGenerator VMMaker.oscog-eem.282 uuid: 6c2f2048-555b-4d37-a9eb-4d9252acf3b9
+	CCodeGenerator VMMaker.oscog-eem.299 uuid: e51057f5-4de2-4c2b-82ce-844d130e2f33
  */
 
 typedef struct {


Property changes on: branches/Cog/platforms/Cross/vm/sqSCCSVersion.h
___________________________________________________________________
Modified: checkindate
   - Wed Jun 12 12:39:49 PDT 2013
   + Fri Jun 14 16:49:42 PDT 2013

Modified: branches/Cog/src/vm/cogit.c
===================================================================
--- branches/Cog/src/vm/cogit.c	2013-06-12 21:59:13 UTC (rev 2742)
+++ branches/Cog/src/vm/cogit.c	2013-06-14 23:51:36 UTC (rev 2743)
@@ -1,9 +1,9 @@
 /* Automatically generated by
-	CCodeGenerator VMMaker.oscog-eem.282 uuid: 6c2f2048-555b-4d37-a9eb-4d9252acf3b9
+	CCodeGenerator VMMaker.oscog-eem.299 uuid: e51057f5-4de2-4c2b-82ce-844d130e2f33
    from
-	StackToRegisterMappingCogit VMMaker.oscog-eem.282 uuid: 6c2f2048-555b-4d37-a9eb-4d9252acf3b9
+	StackToRegisterMappingCogit VMMaker.oscog-eem.299 uuid: e51057f5-4de2-4c2b-82ce-844d130e2f33
  */
-static char __buildInfo[] = "StackToRegisterMappingCogit VMMaker.oscog-eem.282 uuid: 6c2f2048-555b-4d37-a9eb-4d9252acf3b9 " __DATE__ ;
+static char __buildInfo[] = "StackToRegisterMappingCogit VMMaker.oscog-eem.299 uuid: e51057f5-4de2-4c2b-82ce-844d130e2f33 " __DATE__ ;
 char *__cogitBuildInfo = __buildInfo;
 
 
@@ -2433,7 +2433,7 @@
 		/* otherwise attempt to create a closed PIC for the two cases. */
 
 		pic = cogPICSelectornumArgsCase0MethodCase1MethodtagisMNUCase((targetMethod->selector), (targetMethod->cmNumArgs), targetMethod, newTargetMethodOrNil, cacheTag, errorSelectorOrNil == SelectorDoesNotUnderstand);
-		if ((((sqInt)pic)) < 0) {
+		if ((((((sqInt)pic)) >= MaxNegativeErrorCode) && ((((sqInt)pic)) <= -1))) {
 
 			/* For some reason the PIC couldn't be generated, most likely a lack of code memory.
 			   Continue as if this is an unlinked send. */

Modified: branches/Cog/src/vm/cogit.h
===================================================================
--- branches/Cog/src/vm/cogit.h	2013-06-12 21:59:13 UTC (rev 2742)
+++ branches/Cog/src/vm/cogit.h	2013-06-14 23:51:36 UTC (rev 2743)
@@ -1,5 +1,5 @@
 /* Automatically generated by
-	CCodeGenerator VMMaker.oscog-eem.282 uuid: 6c2f2048-555b-4d37-a9eb-4d9252acf3b9
+	CCodeGenerator VMMaker.oscog-eem.299 uuid: e51057f5-4de2-4c2b-82ce-844d130e2f33
  */
 
 

Modified: branches/Cog/src/vm/cogmethod.h
===================================================================
--- branches/Cog/src/vm/cogmethod.h	2013-06-12 21:59:13 UTC (rev 2742)
+++ branches/Cog/src/vm/cogmethod.h	2013-06-14 23:51:36 UTC (rev 2743)
@@ -1,5 +1,5 @@
 /* Automatically generated by
-	CCodeGenerator VMMaker.oscog-eem.282 uuid: 6c2f2048-555b-4d37-a9eb-4d9252acf3b9
+	CCodeGenerator VMMaker.oscog-eem.299 uuid: e51057f5-4de2-4c2b-82ce-844d130e2f33
  */
 
 typedef struct {



More information about the Vm-dev mailing list