[Vm-dev] VM Maker: SlangBrowser-dtl.12.mcz

Nicolas Cellier nicolas.cellier.aka.nice at gmail.com
Wed Mar 20 00:50:34 UTC 2013


Oh I see, endsWithCloseBracket: aStream, typically the use case of
#last that we search to eradicate (anyway, last does not work with
MultiByteFileStream etc...).

In Xtreams, I guess I would wrap the writeStream into a specialized
one, in the spirit of
    String new writing doing: [:char | lastChar := char]
but our Streams are not really composable...

Nicolas

2013/3/20 David T. Lewis <lewis at mail.msen.com>:
>
> On Wed, Mar 20, 2013 at 12:59:23AM +0100, Nicolas Cellier wrote:
>>
>> 2013/3/20  <commits at source.squeak.org>:
>> >
>> > David T. Lewis uploaded a new version of SlangBrowser to project VM Maker:
>> > http://source.squeak.org/VMMaker/SlangBrowser-dtl.12.mcz
>> >
>> > ==================== Summary ====================
>> >
>> > Name: SlangBrowser-dtl.12
>> > Author: dtl
>> > Time: 19 March 2013, 7:34:57.17 pm
>> > UUID: 65db3519-14eb-42c7-a7f6-6eb3a215b8ba
>> > Ancestors: SlangBrowser-dtl.11
>> >
>> > Use ReadWriteStream on: String new in various methods.
>>
>> I did not look usage into code, but simple question: do we need a
>> ReadWriteStream at all here?
>> Otherwise using a String new writeStream would be a good thing to do.
>> If we ever want to clean our Stream hierarchy, we must think of
>> cleaning the client first...
>
> Yes, the ReadWriteStream is needed here.
>
> Dave
>


More information about the Vm-dev mailing list