[Vm-dev] VM Maker: CMakeVMMakerSqueak-tty.74.mcz

commits at source.squeak.org commits at source.squeak.org
Mon Jun 23 14:20:58 UTC 2014


Timothy M uploaded a new version of CMakeVMMakerSqueak to project VM Maker:
http://source.squeak.org/VMMaker/CMakeVMMakerSqueak-tty.74.mcz

==================== Summary ====================

Name: CMakeVMMakerSqueak-tty.74
Author: tty
Time: 23 June 2014, 10:21:27.143 am
UUID: a815a280-7336-43d4-afba-f2f1f87f1005
Ancestors: CMakeVMMakerSqueak-tty.73

changes subclassesDo to allSubclassesDo in the tests.

Added a test to directly invoke the redirect methods.

=============== Diff against CMakeVMMakerSqueak-tty.73 ===============

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testAvailableBuildTypes (in category 'as yet unclassified') -----
  testAvailableBuildTypes
  	"each concrete configuration must report what buildTypes it supports  "
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  					o:= configuration new.
  					(o excludeFromBuild not)                               ""
  						ifTrue:[self assert:(o  availableBuildTypes isKindOf: Collection)]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testBuildDir (in category 'as yet unclassified') -----
  testBuildDir
  	"for each builder, make sure all its configurations provides availbale build directories "
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							o excludeFromBuild not
  								ifTrue:[self assert:(o  buildDir isKindOf: FileDirectory)]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testBuildDirName (in category 'as yet unclassified') -----
  testBuildDirName
  	"for each builder, make sure all its configurations provide a build directory name "
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							(o excludeFromBuild not)                               ""
  								ifTrue:[
  									self assert:(o  buildDirName isString).
  									self assert:(o  buildDirName size > 0)]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testBuildScript (in category 'as yet unclassified') -----
  testBuildScript
  	"for each builder, make sure all its configurations provide a build directory name "
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							(o excludeFromBuild not)                               ""
  								ifTrue:[
  									self assert:(o  buildScript isString).
  									self assert:(o  buildScript size > 0)]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testCogitClass (in category 'as yet unclassified') -----
  testCogitClass
  	"for each builder that does not exclude itself from builds, make sure it returns cogitClass "
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							o excludeFromBuild not                                                     
  							 	ifTrue:[self assert:(o  cogitClass inheritsFrom: Cogit)]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testCommonCompilerFlags (in category 'as yet unclassified') -----
  testCommonCompilerFlags
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  					configuration isAbstractBaseClass   "*"
  					ifFalse:[	o:= configuration new. 
  							self assert:(o commonCompilerFlags isKindOf: Collection)]]].
  
  "*
  SqueakWin32x86Config browse
  the return array embeds 'self executableName' which does not exist in an AbstractBaseClass
  "
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testCoreSources (in category 'as yet unclassified') -----
  testCoreSources
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  					configuration isAbstractBaseClass not
  						ifTrue:[	o:= configuration new.
  								o excludeFromBuild not
  									ifTrue:[self assert:(o  coreSources isArray)]]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testCrossSources (in category 'as yet unclassified') -----
  testCrossSources
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  					configuration isAbstractBaseClass not
  						ifTrue:[
  							o:= configuration new.
  							(o excludeFromBuild not)
  								ifTrue:[	self assert:(o  crossSources isArray)]]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testDirBuildPlatform (in category 'as yet unclassified') -----
  testDirBuildPlatform
  	"for each builder, make sure all its configurations provide a dirSource "
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  									o:= configuration new.
  									self assert:(o  dirBuildPlatform isString)]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testDirSource (in category 'as yet unclassified') -----
  testDirSource
  	"for each builder, make sure all its configurations provide a dirSource "
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  					configuration isAbstractBaseClass not
  						ifTrue:[	o:= configuration new.
  								o excludeFromBuild not
  									ifTrue:[self assert:(o  dirSource isString)]]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testExcludeFromBuild (in category 'as yet unclassified') -----
  testExcludeFromBuild
  	"for each builder, make sure all its includes or excludes itself from a build "
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							self assert:((o excludeFromBuild  basicType) = #Boolean)]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testExectuableName (in category 'as yet unclassified') -----
  testExectuableName
  	"for each builder, make sure all its configurations provide an executableName "
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							(o excludeFromBuild not)
  								ifTrue:[self assert:(o  executableName isString)]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testExecutableType (in category 'as yet unclassified') -----
  testExecutableType
  	"for each builder, make sure all its configurations provide an executableName "
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							(o excludeFromBuild not)
  								ifTrue:[self assert:(o  executableType isString)]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testExternalsModuleDir (in category 'as yet unclassified') -----
  testExternalsModuleDir
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							o excludeFromBuild not                                                     
  								ifTrue:[self assert:(o  externalModulesDir isString)]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testExtraSources (in category 'as yet unclassified') -----
  testExtraSources
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							(o excludeFromBuild not)
  								ifTrue:[self assert:(o  extraSources isString)]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testInterpreterClass (in category 'as yet unclassified') -----
  testInterpreterClass
  	"for each builder that does not exclude itself from builds, make sure it returns an InterpreterClass "
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							o excludeFromBuild not                                                     
  							 	ifTrue:[
  										self assert:(o  interpreterClass inheritsFrom: InterpreterPrimitives).
  										self assert:(o  interpreterClassBuild inheritsFrom: InterpreterPrimitives).
  										self assert:(o  interpreterClassBuildAssert inheritsFrom: InterpreterPrimitives).
  										self assert:(o  interpreterClassBuildAssertITimerHeartbeat inheritsFrom: InterpreterPrimitives).
  										self assert:(o  interpreterClassBuildDebug inheritsFrom: InterpreterPrimitives).
  										self assert:(o  interpreterClassBuildDebugITImerHeartbeat inheritsFrom: InterpreterPrimitives).
  										self assert:(o  interpreterClassBuildITimerHeartbeat inheritsFrom: InterpreterPrimitives).
  										self assert:(o  interpreterClassBuildITimerMultiThreaded inheritsFrom: InterpreterPrimitives).
  										self assert:(o  interpreterClassBuildITimerMultiThreadedAssert inheritsFrom: InterpreterPrimitives).
  										self assert:(o  interpreterClassBuildITimerMultiThreadedDebug inheritsFrom: InterpreterPrimitives)]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testIsAbstractBaseClass (in category 'as yet unclassified') -----
  testIsAbstractBaseClass
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | 
- 				subclassesDo:[:configuration | 
  					self assert:(configuration isAbstractBaseClass basicType = #Boolean)]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testOutputDir (in category 'as yet unclassified') -----
  testOutputDir
  	"for each builder, make sure all its configurations provide an outputDir "
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							(o excludeFromBuild not)
  								ifTrue:[self assert:(o  outputDir isKindOf: FileDirectory)]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testOutputDirName (in category 'as yet unclassified') -----
  testOutputDirName
  	"for each builder, make sure all its configurations provide a build directory name "
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							(o excludeFromBuild not)                               ""
  								ifTrue:[
  									self assert:(o  outputDirName isString).
  									self assert:(o  outputDirName size > 0)]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testPlatformSources (in category 'as yet unclassified') -----
  testPlatformSources
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  					o:= configuration new.
  					(o excludeFromBuild not) | (configuration isAbstractBaseClass)
  						ifTrue:[self assert:(o  platformSources isArray)]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testSrcDir (in category 'as yet unclassified') -----
  testSrcDir
  	"for each builder, make sure all its configurations provide a srcDir "
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  					o:= configuration new.
  					(o excludeFromBuild not) | (configuration isAbstractBaseClass)
  						ifTrue:[self assert:(o  srcDir isKindOf: FileDirectory)]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testTopDir (in category 'as yet unclassified') -----
  testTopDir
  	"for each builder, make sure all its configurations provide a topDir "
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  					o:= configuration new.
  					(o excludeFromBuild not) | (configuration isAbstractBaseClass)
  						ifTrue:[self assert:(o  topDir isKindOf: FileDirectory)]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testVersion (in category 'as yet unclassified') -----
  testVersion
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  					o:= configuration new.
  					(o excludeFromBuild not) | (configuration isAbstractBaseClass)
  						ifTrue:[self assert:(o  version isString)]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakCommonConfigTest>>testdirBuildLanguageVMMM (in category 'as yet unclassified') -----
  testdirBuildLanguageVMMM
  	"for each builder that does not exclude itself from builds, make sure it returns dirBUildLanguageVMMM "
  	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							o excludeFromBuild not                                                     
  							 	ifTrue:[self assert:(o  dirBuildLanguageVMMM isString)]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakMacintoshConfigTest>>testCMakeMacros (in category 'as yet unclassified') -----
  testCMakeMacros
  	#( SqueakMacintoshConfig)
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							(o excludeFromBuild not)
  								ifTrue:[self assert:(o  cMakeMacros isString)]]]
  
  
  
  !

Item was removed:
- ----- Method: CMakeVMMakerSqueakMacintoshConfigTest>>testCommonCompilerFlags (in category 'as yet unclassified') -----
- testCommonCompilerFlags
- 	#( SqueakMacintoshConfig)
- 		do:[:each | 
- 			(Smalltalk at:each) 
- 				subclassesDo:[:configuration | | o |
- 							o:= configuration new.
- 							(o excludeFromBuild not)  |(configuration isAbstractBaseClass)  
- 								ifTrue:[
- 							self assert:(o  commonCompilerFlags isArray).
- "							self assert:(o  compilerFlagsAssert isArray).
- 							self assert:(o  compilerFlagsAssertITimerHeartbeat isArray).
- 							self assert:(o  compilerFlagsBuild isArray).
- 							self assert:(o  compilerFlagsDebug isArray).
- 							self assert:(o  compilerFlagsDebugITimerHeartbeat isArray).
- 							self assert:(o  compilerFlagsIHeartbeatTimer isArray).
- 							self assert:(o  compilerFlagsMultiThreaded isArray).
- 							self assert:(o  compilerFlagsMultiThreadedAssert isArray).
- 							self assert:(o  compilerFlagsMultiThreadedDebug isArray)."]]]!

Item was changed:
  ----- Method: CMakeVMMakerSqueakMacintoshConfigTest>>testExecutableType (in category 'as yet unclassified') -----
  testExecutableType
  	#(#SqueakMacintoshConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  					o:= configuration new.
  					(o excludeFromBuild not) | (configuration isAbstractBaseClass)
  					ifTrue:[self assert:(o  executableType = 'MACOSX_BUNDLE')]]]
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakMacintoshConfigTest>>testPlatformName (in category 'as yet unclassified') -----
  testPlatformName
  	#(#SqueakMacintoshConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							(o excludeFromBuild not) | (configuration isAbstractBaseClass)
  								ifTrue:[self assert:(o  platformName = 'Mac OS' )]]]
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakMacintoshConfigTest>>testResourcesDir (in category 'as yet unclassified') -----
  testResourcesDir
  	self flag:'tty'. "I modified resourcesDir to 'assureExistence' from 'fullname'. if this causes problems, look into that"
  	#(#SqueakMacintoshConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  					o:= configuration new.
  					(o excludeFromBuild not) | (configuration isAbstractBaseClass)
  								ifTrue:[ self assert:(o  resourcesDir isKindOf: FileDirectory)]]]
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakMacintoshConfigTest>>testResourcesDirName (in category 'as yet unclassified') -----
  testResourcesDirName
  	#(#SqueakMacintoshConfig) 
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							(o excludeFromBuild not) | (configuration isAbstractBaseClass)
  								ifTrue:[self assert:(o  resourcesDirName isString)]]]
  
  
  
  !

Item was added:
+ TestCase subclass: #CMakeVMMakerSqueakNoRedirectMethodsTest
+ 	instanceVariableNames: ''
+ 	classVariableNames: ''
+ 	poolDictionaries: ''
+ 	category: 'CMakeVMMakerSqueak-Tests'!
+ 
+ !CMakeVMMakerSqueakNoRedirectMethodsTest commentStamp: 'tty 6/23/2014 10:19' prior: 0!
+ A CMakeVMMakerSqueakRedirectMethodsTest tests that all Concrete Configuration implement the abstract methods of form:
+ makes sure that all the redirect methods are implemented by calling them directly instead of through the redirect mechanism
+ "
+ x
+ 	|d |
+ 	d:= SqueakCMakeVMMakerAbstractBuilder default buildTypeAndDirectoryInfo copy.
+ 	d 
+ 		at: #build put: [self xBuild];
+ 		at: #buildAssert  put: [self xBuildAssert];
+ 		at: #buildAssertITimerHeartbeat  put: [self xBuildAssertITimerHeartbeat];
+             at:#buildDebug  put: [self xBuildDebug];   
+ 		at: #buildDebugITimerHeartbeat  put: [self xBuildDebugITimerHeartbeat ];
+ 		at: #buildITimerHeartbeat  put: [self xBuildITimerHeartbeat];
+ 		at: #buildMultiThreaded  put: [self xBuildMultiThreaded];
+ 		at: #buildMultiThreadedAssert  put: [self xBuildMultiThreadedAssert];
+ 		at: #buildMultiThreadedDebug   put: [self xBuildMultiThreadedDebug ];
+ 		at: #buildNone put:[self xNoBuildType].
+ 	^(d at: buildType) value
+ 
+ "
+ !

Item was added:
+ ----- Method: CMakeVMMakerSqueakNoRedirectMethodsTest>>testCommonCompilerFlags (in category 'as yet unclassified') -----
+ testCommonCompilerFlags
+ "	#(#SqueakWindowsConfig #SqueakUnixConfig #SqueakMacintoshConfig) 
+ 		do:[:each | 
+ 			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
+ 					o:= configuration new.
+ 					(o excludeFromBuild not)  |(configuration isAbstractBaseClass)  
+ 						ifTrue:[
+ 							self assert:(o  commonCompilerFlags isArray).
+ 							self assert:(o  compilerFlagsAssert isArray).
+ 							self assert:(o  compilerFlagsAssertITimerHeartbeat isArray).
+ 							self assert:(o  compilerFlagsBuild isArray).
+ 							self assert:(o  compilerFlagsDebug isArray).
+ 							self assert:(o  compilerFlagsDebugITimerHeartbeat isArray).
+ 							self assert:(o  compilerFlagsIHeartbeatTimer isArray).
+ 							self assert:(o  compilerFlagsMultiThreaded isArray).
+ 							self assert:(o  compilerFlagsMultiThreadedAssert isArray).
+ 							self assert:(o  compilerFlagsMultiThreadedDebug isArray)]]]"!

Item was added:
+ ----- Method: CMakeVMMakerSqueakNoRedirectMethodsTest>>testCompilerFlags (in category 'as yet unclassified') -----
+ testCompilerFlags
+ 	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig ) 
+ 		do:[:each | 
+ 			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
+ 					o:= configuration new.
+ 					(o excludeFromBuild not)  
+ 						ifTrue:[
+ 							self assert:(o  compilerFlagsBuild isArray).
+ 							self assert:(o  compilerFlagsBuildAssert isArray).
+ 							self assert:(o  compilerFlagsBuildAssertITimerHeartbeat isArray).
+ 							self assert:(o  compilerFlagsBuildDebug isArray).
+ 							self assert:(o  compilerFlagsBuildDebugITimerHeartbeat isArray).
+ 							self assert:(o  compilerFlagsBuildITimerHeartbeat isArray).
+ 							self assert:(o  compilerFlagsBuildMultiThreaded isArray).
+ 							self assert:(o  compilerFlagsBuildMultiThreadedAssert isArray).
+ 							self assert:(o  compilerFlagsBuildMultiThreadedDebug isArray)]]]
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ !

Item was added:
+ ----- Method: CMakeVMMakerSqueakNoRedirectMethodsTest>>testLinkFlags (in category 'as yet unclassified') -----
+ testLinkFlags
+ 	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig ) 
+ 		do:[:each | 
+ 			(Smalltalk at:each) 
+ 				subclassesDo:[:configuration | | o |
+ 							o:= configuration new.
+ 							(o excludeFromBuild not)  |(configuration isAbstractBaseClass)  
+ 								ifTrue:[
+ 							o:= configuration new.
+ 							(o excludeFromBuild not)
+ 								ifTrue:[]]]]!

Item was added:
+ ----- Method: CMakeVMMakerSqueakRedirectMethodsTest>>testCommonCompilerFlags (in category 'as yet unclassified') -----
+ testCommonCompilerFlags
+ "	#(#SqueakWindowsConfig #SqueakUnixConfig #SqueakMacintoshConfig) 
+ 		do:[:each | 
+ 			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
+ 					o:= configuration new.
+ 					(o excludeFromBuild not)  |(configuration isAbstractBaseClass)  
+ 						ifTrue:[
+ 							self assert:(o  commonCompilerFlags isArray).
+ 							self assert:(o  compilerFlagsAssert isArray).
+ 							self assert:(o  compilerFlagsAssertITimerHeartbeat isArray).
+ 							self assert:(o  compilerFlagsBuild isArray).
+ 							self assert:(o  compilerFlagsDebug isArray).
+ 							self assert:(o  compilerFlagsDebugITimerHeartbeat isArray).
+ 							self assert:(o  compilerFlagsIHeartbeatTimer isArray).
+ 							self assert:(o  compilerFlagsMultiThreaded isArray).
+ 							self assert:(o  compilerFlagsMultiThreadedAssert isArray).
+ 							self assert:(o  compilerFlagsMultiThreadedDebug isArray)]]]"!

Item was changed:
  ----- Method: CMakeVMMakerSqueakRedirectMethodsTest>>testCompilerFlags (in category 'as yet unclassified') -----
  testCompilerFlags
+ 	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig ) 
+ 		do:[:each | 
+ 			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
+ 					o:= configuration new.
+ 					(o excludeFromBuild not)  
+ 						ifTrue:[
- 	SqueakCMakeVMMakerAbstractBuilder 
- 		subclassesDo:[:builder | | o |
- 			Smalltalk globals 
- 				allClassesDo:[:configuration | (configuration class category asString withoutQuoting startsWith: (builder configurationsCategory))
- 					ifTrue:[ 
- 							o:= configuration new.
- 							(o excludeFromBuild not)
- 								ifTrue:[
  							self assert:(o  compilerFlagsBuild isArray).
  							self assert:(o  compilerFlagsBuildAssert isArray).
  							self assert:(o  compilerFlagsBuildAssertITimerHeartbeat isArray).
  							self assert:(o  compilerFlagsBuildDebug isArray).
  							self assert:(o  compilerFlagsBuildDebugITimerHeartbeat isArray).
  							self assert:(o  compilerFlagsBuildITimerHeartbeat isArray).
  							self assert:(o  compilerFlagsBuildMultiThreaded isArray).
  							self assert:(o  compilerFlagsBuildMultiThreadedAssert isArray).
+ 							self assert:(o  compilerFlagsBuildMultiThreadedDebug isArray)]]]
- 							self assert:(o  compilerFlagsBuildMultiThreadedDebug isArray)]]]]
  
  
  
  
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakRedirectMethodsTest>>testLinkFlags (in category 'as yet unclassified') -----
  testLinkFlags
+ 	#(#SqueakMacintoshConfig #SqueakUnixConfig #SqueakWindowsConfig ) 
+ 		do:[:each | 
+ 			(Smalltalk at:each) 
+ 				subclassesDo:[:configuration | | o |
+ 							o:= configuration new.
+ 							(o excludeFromBuild not)  |(configuration isAbstractBaseClass)  
+ 								ifTrue:[
+ 							o:= configuration new.
+ 							(o excludeFromBuild not)
+ 								ifTrue:[]]]]!
- 	"make sure each enabled Configuration returns from each buildType configuration correctly"
- 	SqueakCMakeVMMakerAbstractBuilder	reset.
- 	SqueakCMakeVMMakerAbstractBuilder 
- 		subclassesDo:[:builder | 
- 			Smalltalk globals 
- 				allClassesDo:[:configuration | (configuration class category asString withoutQuoting startsWith: (builder configurationsCategory))
- 					ifTrue:[ ]]]
- 
- 
- 
- 
- 
- 
- 
- 
- 
- !

Item was removed:
- ----- Method: CMakeVMMakerSqueakUnixConfigTest>>testCommonCompilerFlags (in category 'as yet unclassified') -----
- testCommonCompilerFlags
- 	#( SqueakUnixConfig)
- 		do:[:each | 
- 			(Smalltalk at:each) 
- 				subclassesDo:[:configuration | | o |
- 							o:= configuration new.
- 							(o excludeFromBuild not)  |(configuration isAbstractBaseClass)  
- 								ifTrue:[
- 							self assert:(o  commonCompilerFlags isArray).
- "							self assert:(o  compilerFlagsAssert isArray).
- 							self assert:(o  compilerFlagsAssertITimerHeartbeat isArray).
- 							self assert:(o  compilerFlagsBuild isArray).
- 							self assert:(o  compilerFlagsDebug isArray).
- 							self assert:(o  compilerFlagsDebugITimerHeartbeat isArray).
- 							self assert:(o  compilerFlagsIHeartbeatTimer isArray).
- 							self assert:(o  compilerFlagsMultiThreaded isArray).
- 							self assert:(o  compilerFlagsMultiThreadedAssert isArray).
- 							self assert:(o  compilerFlagsMultiThreadedDebug isArray)."]]]
- 
- 
- 
- 
- 
- 
- 
- !

Item was changed:
  ----- Method: CMakeVMMakerSqueakUnixConfigTest>>testConfigH (in category 'as yet unclassified') -----
  testConfigH
  	#( SqueakUnixConfig)
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							(o excludeFromBuild not)  |(configuration isAbstractBaseClass not)  
  								ifTrue:[
  							o:= configuration new.
  							(o excludeFromBuild not)
  								ifTrue:[self assert:(o  configH isString)]]]]
  
  
  
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakUnixConfigTest>>testExecutableType (in category 'as yet unclassified') -----
  testExecutableType
  	#( SqueakUnixConfig)
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							(o excludeFromBuild not)  |(configuration isAbstractBaseClass not)  
  								ifTrue:[
  							o:= configuration new.
  							self assert:(o  executableType = '').]]]    "hello code smell"
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakUnixConfigTest>>testPlatformName (in category 'as yet unclassified') -----
  testPlatformName
  		self flag:'tty'. "todo: fix code smell in hard coded string"
  	#( SqueakUnixConfig)
  		do:[:each | 
  			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
- 				subclassesDo:[:configuration | | o |
  							o:= configuration new.
  							(o excludeFromBuild not)  |(configuration isAbstractBaseClass not)  
  								ifTrue:[
  							o:= configuration new.
  							(o excludeFromBuild not)
  								ifTrue:[self assert:(o  platformName = 'unix' )]]]]
  
  !

Item was removed:
- ----- Method: CMakeVMMakerSqueakWindowsConfigTest>>testCommonCompilerFlags (in category 'as yet unclassified') -----
- testCommonCompilerFlags
- 		""
- 		self flag:'tty'. "I need to differentiate this from the test in CommonConfigTests. Also, why is windows Array and others String?"
- 	#(#SqueakWindowsConfig) 
- 		do:[:each | 
- 			(Smalltalk at:each) 
- 				subclassesDo:[:configuration | | o |
- 							o:= configuration new.
- 							(o excludeFromBuild not)  |(configuration isAbstractBaseClass)  
- 								ifTrue:[
- 							self assert:(o  commonCompilerFlags isArray).
- "							self assert:(o  compilerFlagsAssert isArray).
- 							self assert:(o  compilerFlagsAssertITimerHeartbeat isArray).
- 							self assert:(o  compilerFlagsBuild isArray).
- 							self assert:(o  compilerFlagsDebug isArray).
- 							self assert:(o  compilerFlagsDebugITimerHeartbeat isArray).
- 							self assert:(o  compilerFlagsIHeartbeatTimer isArray).
- 							self assert:(o  compilerFlagsMultiThreaded isArray).
- 							self assert:(o  compilerFlagsMultiThreadedAssert isArray).
- 							self assert:(o  compilerFlagsMultiThreadedDebug isArray)."
- 
- 
- 								]]]
- 
- 
- 
- 
- 
- 
- 
- !

Item was changed:
  ----- Method: CMakeVMMakerSqueakWindowsConfigTest>>testExecutableType (in category 'as yet unclassified') -----
  testExecutableType
  
+ 	#(#SqueakWindowsConfig) 
+ 		do:[:each | 
+ 			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
+ 					o:= configuration new.
+ 					(o excludeFromBuild not)  |(configuration isAbstractBaseClass)  
+ 						ifTrue:[
+ 								o:= configuration new.
+ 								self assert:(o  executableType = 'WIN32').  "hello code smell"]]]
- 		#(#SqueakWin32x86Builder) 
- 		do:[:builder | | o |
- 			Smalltalk globals 
- 				allClassesDo:[:configuration | (configuration class category asString withoutQuoting startsWith: ((Smalltalk at:builder)  configurationsCategory))
- 					ifTrue:[ 
- 							o:= configuration new.
- 							self assert:(o  executableType = 'WIN32').  "hello code smell"
  
  
- 								]]]
  
  
  
  
  
- 
- 
  !

Item was changed:
  ----- Method: CMakeVMMakerSqueakWindowsConfigTest>>testPlatformName (in category 'as yet unclassified') -----
  testPlatformName
  		self flag:'tty'. "todo: fix code smell in hard coded string"
+ 	#(#SqueakWindowsConfig) 
+ 		do:[:each | 
+ 			(Smalltalk at:each) 
+ 				allSubclassesDo:[:configuration | | o |
+ 					o:= configuration new.
+ 					(o excludeFromBuild not)  |(configuration isAbstractBaseClass)  
+ 						ifTrue:[
+ 								o:= configuration new.
+ 								self assert:(o  platformName = 'win32').  "hello code smell"]]]
- 		#(#SqueakWin32x86Builder) 
- 		do:[:builder | | o |
- 			Smalltalk globals 
- 				allClassesDo:[:configuration | (configuration class category asString withoutQuoting startsWith: ((Smalltalk at:builder)  configurationsCategory))
- 					ifTrue:[ 
- 							o:= configuration new.
- 							self assert:(o  platformName = 'win32').  "hello code smell"
  
  
- 								]]]
  
  
  
  
  
- 
- 
  !



More information about the Vm-dev mailing list