[Vm-dev] VM Maker: VMMaker.oscog-nice.1830.mcz

[Nicolas Cellier]

2016-04-22 0:50 GMT+02:00 Levente Uzonyi <leves at caesar.elte.hu>:

>
> On Thu, 21 Apr 2016, commits at source.squeak.org wrote:
>
>
>> Nicolas Cellier uploaded a new version of VMMaker to project VM Maker:
>> http://source.squeak.org/VMMaker/VMMaker.oscog-nice.1830.mcz
>>
>>
> snip
>
> + ----- Method:
>> VMPluginCodeGenerator>>preDeclareMacrosForFastClassChekingOn: (in category
>> 'C code generator') -----
>> + preDeclareMacrosForFastClassChekingOn: aStream
>> +       "These macros can be used to check for various case of Integer
>> type.
>> +       Since they can be defined based on existing API, this is a good
>> trade off:
>> +       - avoid extending the interpreterProxy API like mad
>> +       - provide fast type checking"
>> +
>> +       "Fast-up generated code by using a macro for this well known
>> function unconditionnally"
>> +       aStream cr; nextPutAll: '#define isIntegerObject(oop) (oop & 1)';
>> cr.
>> +
>> +       aStream cr; nextPutAll: '#if SPURVM &&
>> defined(SQUEAK_BUILTIN_PLUGIN)'.
>> +
>> +       "Compact class index are hardcoded because there is no guaranty
>> that the pool values at generation time are that of SPUR..
>> +        Make sure they are in sync with SpurMemoryManager
>> class>>initializeCompactClassIndices"
>> +       aStream cr; nextPutAll: '# define LargeNegativeIntegerClassIndex
>> 32'.
>> +       aStream cr; nextPutAll: '# define LargePositiveIntegerClassIndex
>> 33'.
>> +       aStream cr; nextPutAll: 'extern sqInt classIndexOf(sqInt);'.
>> +       aStream cr; nextPutAll: '# define isKindOfInteger(oop)
>> (isImmediate(oop) ? isIntegerObject(oop) : (unsigned)(classIndexOf(oop) -
>> LargeNegativeIntegerClassIndex) <= 1)'.
>> +       aStream cr; nextPutAll: '# define isLargeIntegerObject(oop)
>> (!!isImmediate(oop) && (unsigned)(classIndexOf(oop) -
>> LargeNegativeIntegerClassIndex) <= 1)'.
>> +       aStream cr; nextPutAll: '# define
>> isLargeNegativeIntegerObject(oop) (!!isImmediate(oop) && classIndexOf(oop)
>> == LargeNegativeIntegerClassIndex)'.
>> +       aStream cr; nextPutAll: '# define
>> isLargePositiveIntegerObject(oop) (!!isImmediate(oop) && classIndexOf(oop)
>> == LargePositiveIntegerClassIndex)'.
>> +
>> +       aStream cr; nextPutAll: '#else /* defined(SQUEAK_BUILTIN_PLUGIN)
>> && defined(SPURVM) */'.
>>
>
> These macros look pretty good. I wonder if we can have more, e.g.
> #classIndexOf:. IIRC that's part of the object header in Spur. If so, then
> we could use a macro for that as well, couldn't we?
>

Yes, I was thinking of it.
Ideally I would have wanted this macro to be automatically generated from
current source.
That means picking the right set of vm classes (the plugins are not
necessarily generated from spur)
Then transform the method and sent methods, inline, check if it can be
generated as macro (no temp vars, no side effect,...), remove return &
parameter type declarations, appropriately place parentheses and protect
intermediate end of lines \

For sure, for just a function it's not worth, better duplicate code...
But this scheme would be extensible.



>
> Btw, the comment here and below don't match the actual #if.
>

Ah good eyes, I modified only the first and forgot the two others


> Also, there's a "c" missing from the name of the method: Cheking vs
> Checking.
>
> excellent eyes, I missed it.

I'll fix it when I'll have something else to commit.


> Levente
>
> +
>> +       aStream cr; nextPutAll: '# define
>> isLargeNegativeIntegerObject(oop) (fetchClassOf(oop) ==
>> classLargeNegativeInteger())'.
>> +       aStream cr; nextPutAll: '# define
>> isLargePositiveIntegerObject(oop) (fetchClassOf(oop) ==
>> classLargePositiveInteger())'.
>> +       aStream cr; nextPutAll: '# define isLargeIntegerObject(oop)
>> (isLargeNegativeIntegerObject(oop) || isLargePositiveIntegerObject(oop))'.
>> +       aStream cr; nextPutAll: '# define isKindOfInteger(oop)
>> (isIntegerObject(oop) || isLargeNegativeIntegerObject(oop) ||
>> isLargePositiveIntegerObject(oop))'.
>> +
>> +       aStream cr; nextPutAll: '#endif /* defined(SQUEAK_BUILTIN_PLUGIN)
>> && defined(SPURVM) */'; cr
>> +       !
>>
>> Item was added:
>> + ----- Method: VMPluginCodeGenerator>>selectorsThatAreGeneratedAsMacros
>> (in category 'public') -----
>> + selectorsThatAreGeneratedAsMacros
>> +       "Answer a list of selectors that are generated as a C macro
>> rather than as an interpreterProxy function call."
>> +
>> +       ^#(isKindOfInteger: isIntegerObject: isLargeIntegerObject:
>> isLargeNegativeIntegerObject: isLargePositiveIntegerObject:)!
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20160422/2bab4f7f/attachment.htm