[Vm-dev] [commit][3682] Remove double backslashes at end of default implementation of new swap macros .

[Eliot Miranda]

Hi Nicolas,


> On Apr 22, 2016, at 11:52 PM, Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com> wrote:
> 
> Ouch, I wonder how I could introduce these :(

Never mind.  You didn't do it on purpose.  Some stupid tool probably did it for you.  You can imagine how frustrating it is to discover midway through a build on 6 platforms using three Parallels VMs and a pi2, having to restart the builds on each commit ;-). Three times :-).  Ugh...

> 
> 2016-04-23 5:23 GMT+02:00 <commits at squeakvm.org>:
>> 
>> Revision: 3682
>> Author:   eliot
>> Date:     2016-04-22 20:23:49 -0700 (Fri, 22 Apr 2016)
>> Log Message:
>> -----------
>> Remove double backslashes at end of default implementation of new swap macros.
>> 
>> Modified Paths:
>> --------------
>>     branches/Cog/platforms/Cross/vm/sqMemoryAccess.h
>> 
>> Property Changed:
>> ----------------
>>     branches/Cog/platforms/Cross/vm/sqSCCSVersion.h
>> 
>> Modified: branches/Cog/platforms/Cross/vm/sqMemoryAccess.h
>> ===================================================================
>> --- branches/Cog/platforms/Cross/vm/sqMemoryAccess.h    2016-04-23 00:59:25 UTC (rev 3681)
>> +++ branches/Cog/platforms/Cross/vm/sqMemoryAccess.h    2016-04-23 03:23:49 UTC (rev 3682)
>> @@ -218,18 +218,18 @@
>>  #  define SQ_SWAP_8_BYTES(x) _byteswap_uint64(x)
>>  #else
>>  #  define SQ_SWAP_4_BYTES(x) \
>> -       (((unsigned int)(x) << 24) | \\
>> -       (((unsigned int)(x) <<  8) & 0xff0000U) | \\
>> -       (((unsigned int)(x) >>  8) & 0xff00U) | \\
>> +       (((unsigned int)(x) << 24) | \
>> +       (((unsigned int)(x) <<  8) & 0xff0000U) | \
>> +       (((unsigned int)(x) >>  8) & 0xff00U) | \
>>         ( (unsigned int)(x) >> 24))
>>  #  define SQ_SWAP_8_BYTES(x) \
>> -       (((unsigned long long)(x) << 56) | \\
>> -       (((unsigned long long)(x) << 40) & 0xff000000000000ULL) | \\
>> -       (((unsigned long long)(x) << 24) & 0xff0000000000ULL) | \\
>> -       (((unsigned long long)(x) << 8)  & 0xff00000000ULL) | \\
>> -       (((unsigned long long)(x) >> 8)  & 0xff000000ULL) | \\
>> -       (((unsigned long long)(x) >> 24) & 0xff0000ULL) | \\
>> -       (((unsigned long long)(x) >> 40) & 0xff00ULL) | \\
>> +       (((unsigned long long)(x) << 56) | \
>> +       (((unsigned long long)(x) << 40) & 0xff000000000000ULL) | \
>> +       (((unsigned long long)(x) << 24) & 0xff0000000000ULL) | \
>> +       (((unsigned long long)(x) << 8)  & 0xff00000000ULL) | \
>> +       (((unsigned long long)(x) >> 8)  & 0xff000000ULL) | \
>> +       (((unsigned long long)(x) >> 24) & 0xff0000ULL) | \
>> +       (((unsigned long long)(x) >> 40) & 0xff00ULL) | \
>>         ( (unsigned long long)(x) >> 56))
>>  #endif
>> 
>> 
>> 
>> Property changes on: branches/Cog/platforms/Cross/vm/sqSCCSVersion.h
>> ___________________________________________________________________
>> Modified: checkindate
>>    - Fri Apr 22 17:58:08 PDT 2016
>>    + Fri Apr 22 20:22:44 PDT 2016
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20160423/c1bf2481/attachment.htm