[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 16fa74: Fix passing of floating point via registers for x6...

GitHub noreply at github.com
Thu Aug 11 17:05:17 UTC 2016


  Branch: refs/heads/LLP64
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 16fa742ffecee1b0e7257b720a88ff194f1f98b6
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/16fa742ffecee1b0e7257b720a88ff194f1f98b6
  Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
  Date:   2016-08-11 (Thu, 11 Aug 2016)

  Changed paths:
    M src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c

  Log Message:
  -----------
  Fix passing of floating point via registers for x64 win64.

Note 1:
The hack previously used (overriding the accessor for floatRegisterIndex) didn't work.
Indeed, it was superseded by a greater hack that avoid generating the accessors.
Every hacker should be humble, especially when adding hacks over hacks.

Note 2:
Now the 33 tests for FFI-Tests-EstebanLorenzano.8 are passing
TODO: also test the callback infrastructure




More information about the Vm-dev mailing list