[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 1f82cb: Force remove config.h in mvm scripts

Fabio Niephaus lists at fniephaus.com
Wed Aug 17 21:05:37 UTC 2016


Hi Eliot,

I didn't know about your use case and thought the following made sense:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3e2b3e429307bff51036ebdf551261e715af337b#commitcomment-18530321

`rm` with the -f option failed with a non-zero exit code which caused mvn
scripts to fail if a config.h did not exist. I was under the impression
that the force option avoids an error exit code, avoids being prompted,
and bypasses permission checks. I wonder, did you really change the
permissions in order to preserve config.h files? Otherwise `rm config.h`
should do the same as `rm -f config.h`, right?
As a workaround, we could use `rm config.h || true` instead, if that solves
your problem.

Let me know what you think,
Fabio

-- 

On Wed, Aug 17, 2016 at 10:37 PM Eliot Miranda <eliot.miranda at gmail.com>
wrote:

>
> Hi Fabio,  Hi All,
>
>
>     so there's a reason why the scripts don't force removal, and that's
> the use case of someone developing the VM, doing repeated compiles, where
> to wait for an entire autoconfig step on each build reduces productivity
> enormously; one can wait for two or three minutes for the autoconfig steps
> that generate config.h on a production, assert, debug trio of builds.
>
> Now, Esteban is working on refactoring the autoconfig step so that it
> happens once per platform rather than once per build, but perhaps the right
> way to approach this in the meantime is to have Jenkins force the removal
> via a flag to mvm and leave the default case to not delete config.h.
> Please make the system easier for VM developers; the computer slaves can be
> loaded up with work, not the humans please.
>
>
> On Fri, Aug 5, 2016 at 1:41 AM, GitHub <noreply at github.com> wrote:
>
>>
>>   Branch: refs/heads/Cog
>>   Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
>>   Commit: 1f82cbdeec1dfd6072014fccfab4c9db38e9b925
>>
>> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1f82cbdeec1dfd6072014fccfab4c9db38e9b925
>>   Author: Fabio Niephaus <code at fniephaus.com>
>>   Date:   2016-08-05 (Fri, 05 Aug 2016)
>>
>>   Changed paths:
>>     M build.linux32ARMv6/newspeak.stack.spur/build.assert/mvm
>>     M build.linux32ARMv6/newspeak.stack.spur/build.debug/mvm
>>     M build.linux32ARMv6/newspeak.stack.spur/build/mvm
>>     M build.linux32ARMv6/squeak.stack.spur/build.assert/mvm
>>     M build.linux32ARMv6/squeak.stack.spur/build.debug/mvm
>>     M build.linux32ARMv6/squeak.stack.spur/build/mvm
>>     M build.linux32ARMv6/squeak.stack.v3/build.assert/mvm
>>     M build.linux32ARMv6/squeak.stack.v3/build.debug/mvm
>>     M build.linux32ARMv6/squeak.stack.v3/build/mvm
>>     M build.linux32ARMv7/newspeak.stack.spur/build.assert/mvm
>>     M build.linux32ARMv7/newspeak.stack.spur/build.debug/mvm
>>     M build.linux32ARMv7/newspeak.stack.spur/build/mvm
>>     M build.linux32x86/newspeak.cog.spur/build.assert.itimerheartbeat/mvm
>>     M build.linux32x86/newspeak.cog.spur/build.assert/mvm
>>     M build.linux32x86/newspeak.cog.spur/build.debug.itimerheartbeat/mvm
>>     M build.linux32x86/newspeak.cog.spur/build.debug/mvm
>>     M build.linux32x86/newspeak.cog.spur/build.itimerheartbeat/mvm
>>     M build.linux32x86/newspeak.cog.spur/build/mvm
>>     M build.linux32x86/newspeak.stack.spur/build.assert/mvm
>>     M build.linux32x86/newspeak.stack.spur/build.debug/mvm
>>     M build.linux32x86/newspeak.stack.spur/build/mvm
>>     M build.linux32x86/nsnac.cog.spur/build.assert.itimerheartbeat/mvm
>>     M build.linux32x86/nsnac.cog.spur/build.assert/mvm
>>     M build.linux32x86/nsnac.cog.spur/build.debug.itimerheartbeat/mvm
>>     M build.linux32x86/nsnac.cog.spur/build.debug/mvm
>>     M build.linux32x86/nsnac.cog.spur/build.itimerheartbeat/mvm
>>     M build.linux32x86/nsnac.cog.spur/build/mvm
>>     M build.linux32x86/squeak.stack.spur/build.assert/mvm
>>     M build.linux32x86/squeak.stack.spur/build.debug/mvm
>>     M build.linux32x86/squeak.stack.spur/build/mvm
>>     M build.linux32x86/squeak.stack.v3/build.assert/mvm
>>     M build.linux32x86/squeak.stack.v3/build.debug/mvm
>>     M build.linux32x86/squeak.stack.v3/build/mvm
>>     M build.linux64x64/newspeak.cog.spur/build.assert.itimerheartbeat/mvm
>>     M build.linux64x64/newspeak.cog.spur/build.assert/mvm
>>     M build.linux64x64/newspeak.cog.spur/build.debug.itimerheartbeat/mvm
>>     M build.linux64x64/newspeak.cog.spur/build.debug/mvm
>>     M build.linux64x64/newspeak.cog.spur/build.itimerheartbeat/mvm
>>     M build.linux64x64/newspeak.cog.spur/build/mvm
>>     M build.linux64x64/newspeak.stack.spur/build.assert/mvm
>>     M build.linux64x64/newspeak.stack.spur/build.debug/mvm
>>     M build.linux64x64/newspeak.stack.spur/build/mvm
>>
>>   Log Message:
>>   -----------
>>   Force remove config.h in mvm scripts
>>
>>
>> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3e2b3e429307bff51036ebdf551261e715af337b#commitcomment-18530321
>>
>> /cc @bwestergaard @krono [ci skip]
>>
>>
>>
>>
>
>
> --
> _,,,^..^,,,_
> best, Eliot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20160817/ae1b5483/attachment.htm


More information about the Vm-dev mailing list