[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 08822c: Revise valid
macro for LLP64 case in sqWin32Backtr...
David T. Lewis
lewis at mail.msen.com
Thu Jul 7 16:03:15 UTC 2016
sqInt is not always large enough to hold a pointer, in particular for the
common case of a 64-bit VM running a 32-bit object memory (yes I know
there is not currently such a configuration for Cog/Spur). It would be
good to avoid that assumption if possible.
> Branch: refs/heads/Cog
> Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
> Commit: 08822ce610c20b61e1faec0ce72e635c8ad10e7c
> Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
> Date: 2016-07-07 (Thu, 07 Jul 2016)
> Changed paths:
> M platforms/win32/vm/sqWin32Backtrace.c
> Log Message:
> Revise valid macro for LLP64 case in sqWin32Backtrace.c
> The code would have truncated fp bits because sizeof(long) > sizeof(fp) in
> It would have worked because we only inspect least significant bits for
> But it's better to suppress suspicious compiler warning.
> Thus use sqInt which is allways large enough to hold a pointer.
More information about the Vm-dev