[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 08822c: Revise valid macro for LLP64 case in sqWin32Backtr...

[Eliot Miranda]

Hi David,

On Thu, Jul 7, 2016 at 9:03 AM, David T. Lewis <lewis at mail.msen.com> wrote:

>
> sqInt is not always large enough to hold a pointer, in particular for the
> common case of a 64-bit VM running a 32-bit object memory (yes I know
> there is not currently such a configuration for Cog/Spur). It would be
> good to avoid that assumption if possible.
>

I wonder what the benefit of trying to maintain the   64-bit VM running a
32-bit object memory configuration is, now that we have an efficient 64-bit
on 64-bit configuration.  This is costly to maintain, and unless people
really want to use it for me it feels like wasted effort.  I realise it's
your baby, and that it may have meaning.  But it's also a hungry mouth to
feed...


> Dave
>
> >    Branch: refs/heads/Cog
> >   Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
> >   Commit: 08822ce610c20b61e1faec0ce72e635c8ad10e7c
> >
> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/08822ce610c20b61e1faec0ce72e635c8ad10e7c
> >   Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
> >   Date:   2016-07-07 (Thu, 07 Jul 2016)
> >
> >   Changed paths:
> >     M platforms/win32/vm/sqWin32Backtrace.c
> >
> >   Log Message:
> >   -----------
> >   Revise valid macro for LLP64 case in sqWin32Backtrace.c
> >
> > The code would have truncated fp bits because sizeof(long) > sizeof(fp)
> in
> > LLP64
> > It would have worked because we only inspect least significant bits for
> > alignment
> > But it's better to suppress suspicious compiler warning.
> > Thus use sqInt which is allways large enough to hold a pointer.
> >
> >
> >
>
>
>


-- 
_,,,^..^,,,_
best, Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20160707/e9ce627a/attachment.htm