[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 70b7ac: Make win32 file plugin LLP64 compatible

GitHub noreply at github.com
Mon Jul 18 10:27:49 UTC 2016


  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 70b7ac5ce1008c34dce3d60623e1fdb15ffb7e34
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/70b7ac5ce1008c34dce3d60623e1fdb15ffb7e34
  Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
  Date:   2016-07-18 (Mon, 18 Jul 2016)

  Changed paths:
    M platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c
    M platforms/win32/vm/sqPlatformSpecific.h

  Log Message:
  -----------
  Make win32 file plugin LLP64 compatible

sqImageFile must be large enough to hold a handle


  Commit: 898e642e0241676067b5d2cd46af0b91b58696a6
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/898e642e0241676067b5d2cd46af0b91b58696a6
  Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
  Date:   2016-07-18 (Mon, 18 Jul 2016)

  Changed paths:
    M platforms/win32/vm/sqWin32HandleTable.h

  Log Message:
  -----------
  Suppress a compiler warning in Win32HandleTable

Note: the warning was a false positive, no matter at which index we start the search as long as it's less than table->size


  Commit: 75aff560b713c07f6da22757d0af5457a249ae88
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/75aff560b713c07f6da22757d0af5457a249ae88
  Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
  Date:   2016-07-18 (Mon, 18 Jul 2016)

  Changed paths:
    M platforms/win32/plugins/HostWindowPlugin/sqWin32HostWindowPlugin.c

  Log Message:
  -----------
  Make win32 Host Window Plugin LLP64 compatible.

1) The bitsPtr cannot be stored in an int.
2) don't cast the handle to an int in createWindowWidthheightoriginXyattrlength return value

TODO: for 32bits image on 64bits VM, createWindow should rather return a usqIntptr_t
That means changes in VMMaker and other platforms specific code


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/b7e463bd3fc9...75aff560b713


More information about the Vm-dev mailing list