[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 423aea: MSVC: do not include windef.h in your code

GitHub noreply at github.com
Sat Jul 23 21:28:37 UTC 2016

  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 423aeac78fc105b8182ff8fdd462093fba98b671
  Author: nicolas-cellier-aka-nice <nicolas.cellier.aka.nice at gmail.com>
  Date:   2016-07-23 (Sat, 23 Jul 2016)

  Changed paths:
    M platforms/win32/vm/sqWin32Threads.c

  Log Message:
  MSVC: do not include windef.h in your code

See http://stackoverflow.com/questions/4845198/fatal-error-no-target-architecture-in-visual-studio
That's exactly the error we get with MSVC 2015:
>C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\include\winnt.h(135): fatal error C1189: #error :  "No Target Architecture"

The good practice is to include <windows.h>, and it's also true for mingw.
(this change also fix a _STRUCT_NAME redefinition warning with mingw).

More information about the Vm-dev mailing list