[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 0aa655: Replace fsync by FlushFileBuffers for MSVC

[Nicolas Cellier]

Thanks Tim,
I replicated this discussion as github comment
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0aa65563f90b6f8f83a8126e37647bca4fda2ba5
because I feel like it's closer to the source code than this list.
However, since the comments are not reported here, I wonder what is the
most efficient... (less eyes?).

Since the windows version is optional (subject to -DWIN32_FILE_SUPPORT),
maybe we can keep my change.
On the other hand, the duplication sounds strange...
Having this compiler def. mandatory for MSVC would not hurt me.


2016-07-24 20:20 GMT+02:00 tim Rowledge <tim at rowledge.org>:

>
> HI Nicolas-
> > On 24-07-2016, at 10:13 AM, GitHub <noreply at github.com> wrote:
> >
> >  Branch: refs/heads/Cog
> >  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
> >  Commit: 0aa65563f90b6f8f83a8126e37647bca4fda2ba5
> >
> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0aa65563f90b6f8f83a8126e37647bca4fda2ba5
> >  Author: nicolas-cellier-aka-nice <nicolas.cellier.aka.nice at gmail.com>
> >  Date:   2016-07-24 (Sun, 24 Jul 2016)
> >
> >  Changed paths:
> >    M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c
> >
> >  Log Message:
> >  -----------
> >  Replace fsync by FlushFileBuffers for MSVC
>
> I think Windows doesn’t actually use the
> Cross/blah-blah/sqFilePluginBasicPrims code? Or at least, I’m pretty sure I
> remember  discovering that it didn’t some considerable time ago.
> Certainly the copies of the files I see on my fairly fresh update suggest
> I’m remembering correctly; note how
> /vm/platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c implements
> sqFileTruncate/sqImageFileSeek/etc,etc.
>
>
> tim
> --
> tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
> Useful random insult:- Moves his lips to pretend he's reading.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20160724/f0137161/attachment-0001.htm