[Vm-dev] VM Maker: VMMaker.oscog-tfel.1863.mcz

[Ben Coman]

Hi Tim,

I just ran ./buildspurtrunkvmmakerimage.sh(**1) and I'm bumping into a
halt introduced in 1863...
Is it required :) ?

I see the other halt was previously uncommented.  Is that the usual state?

btw, Are you able to define a general sort of problem that you find
halts useful at this location?


**1 Excluding ./updatespurimage.sh which had a problem I noted in
another thread.


cheers -ben




On Fri, May 20, 2016 at 7:52 PM,  <commits at source.squeak.org> wrote:
>
> Tim Felgentreff uploaded a new version of VMMaker to project VM Maker:
> http://source.squeak.org/VMMaker/VMMaker.oscog-tfel.1863.mcz
>
> ==================== Summary ====================
>
> Name: VMMaker.oscog-tfel.1863
> Author: tfel
> Time: 20 May 2016, 1:52:06.566311 pm
> UUID: 8e524803-55af-ec4b-aa97-9403376a9b13
> Ancestors: VMMaker.oscog-tfel.1862, VMMaker.oscog-eem.1861
>
> Fix Integer>>signedIntFromLong, this should really return a 32-bit signed integer, regardless of the platform's integer size.
>

> Item was changed:
>   ----- Method: StackInterpreterSimulator>>primitiveExecuteMethodArgsArray (in category 'control primitives') -----
>   primitiveExecuteMethodArgsArray
> +       self halt: thisContext selector.
> +       "(objectMemory isOopCompiledMethod: self stackTop) ifFalse:
> +               [self halt]."
> -       "self halt: thisContext selector."
> -       (objectMemory isOopCompiledMethod: self stackTop) ifFalse:
> -               [self halt].
>         ^super primitiveExecuteMethodArgsArray!