[Vm-dev] [commit][3697] Turn ARC On for 64bit compiles, don't make MIDI, fix various issues with bridge and windowIndex for ARC, fix parseArgument data type warning

[Nicolas Cellier]

BTW, I have also this change:

vn diff platforms/iOS/vm/OSX/sqMacV2Window.m
Index: platforms/iOS/vm/OSX/sqMacV2Window.m
===================================================================
--- platforms/iOS/vm/OSX/sqMacV2Window.m    (revision 3702)
+++ platforms/iOS/vm/OSX/sqMacV2Window.m    (working copy)
@@ -53,7 +53,7 @@
     width  = (unsigned) getSavedWindowSize() >> 16;
     height = getSavedWindowSize() & 0xFFFF;
     windowBlock = AddWindowBlock();
-    windowBlock-> handle = gDelegateApp.window;
+    windowBlock-> handle = (__bridge void *)gDelegateApp.window;
     windowBlock->context = nil;
     windowBlock->updateArea = CGRectZero;
     width  = (usqInt) ioScreenSize() >> 16;

John, do you think it's correct?

2016-05-06 21:42 GMT+02:00 Nicolas Cellier <
nicolas.cellier.aka.nice at gmail.com>:

> Strange...
> I've set the -fobjc-arc in build.macos32x86/common/Makefile.flags for
> months
> (along with same .m corrections as John)
> and it looks like working...
> (at least clang does not bark).
>
> Nicolas
>
> 2016-05-05 21:54 GMT+02:00 John McIntosh <johnmci at smalltalkconsulting.com>
> :
>
>>
>> ARC is not supported by the os-x 32bit legacy objective-C runtime kernel.
>>
>> On Thu, May 5, 2016 at 12:23 PM, Eliot Miranda <eliot.miranda at gmail.com>
>> wrote:
>>
>>>
>>> Hi John,
>>>
>>> On Thu, May 5, 2016 at 10:57 AM, <commits at squeakvm.org> wrote:
>>>
>>>>
>>>> Revision: 3697
>>>> Author:   johnmci
>>>> Date:     2016-05-05 10:57:28 -0700 (Thu, 05 May 2016)
>>>> Log Message:
>>>> -----------
>>>> Turn ARC On for 64bit compiles, don't make MIDI, fix various issues
>>>> with bridge and windowIndex for ARC, fix parseArgument data type warning
>>>>
>>>
>>> Curious (ok, ignorant).  Why use ARC for 64-bits but weak for 32-bits?
>>> WOup;don't it be better to go with one approach for both?  If ARC is the
>>> future why not change the 32-bit compile to ARC too?
>>>
>>>  [snip]
>>>
>>>> Modified: branches/Cog/build.macos32x86/common/Makefile.flags
>>>> ===================================================================
>>>> --- branches/Cog/build.macos32x86/common/Makefile.flags 2016-05-05
>>>> 17:18:10 UTC (rev 3696)
>>>> +++ branches/Cog/build.macos32x86/common/Makefile.flags 2016-05-05
>>>> 17:57:28 UTC (rev 3697)
>>>> @@ -9,7 +9,7 @@
>>>>  SDKs:=MacOSX10.12.sdk MacOSX10.11.sdk MacOSX10.10.sdk MacOSX10.9.sdk
>>>>  SDK:=$(firstword $(realpath $(addprefix $(SDKsDIR)/, $(SDKs))))
>>>>  TARGET_ARCH:=i386
>>>> -TARGET_VERSION_MIN:=10.6
>>>> +TARGET_VERSION_MIN:=10.7
>>>>
>>>>  CFLAGS:=$(CFLAGS) -DBUILD_FOR_OSX=1 \
>>>>                 -arch $(TARGET_ARCH) \
>>>> @@ -17,6 +17,7 @@
>>>>                         -fvisibility=default -fwrapv \
>>>>                         -fmacro-backtrace-limit=0
>>>> -fdiagnostics-show-note-include-stack \
>>>>                         -fmessage-length=0 -fpascal-strings
>>>> -fasm-blocks -fstrict-aliasing \
>>>> +                       -fobjc-weak \
>>>>                 -isysroot $(SDK) \
>>>>                 -include $(PLATDIR)/iOS/vm/SqueakPureObjc_Prefix.pch
>>>
>>> [snip]
>>>
>>>> Modified: branches/Cog/build.macos64x64/common/Makefile.flags
>>>> ===================================================================
>>>> --- branches/Cog/build.macos64x64/common/Makefile.flags 2016-05-05
>>>> 17:18:10 UTC (rev 3696)
>>>> +++ branches/Cog/build.macos64x64/common/Makefile.flags 2016-05-05
>>>> 17:57:28 UTC (rev 3697)
>>>> @@ -9,7 +9,7 @@
>>>>  SDKs:=MacOSX10.12.sdk MacOSX10.11.sdk MacOSX10.10.sdk MacOSX10.9.sdk
>>>>  SDK:=$(firstword $(realpath $(addprefix $(SDKsDIR)/, $(SDKs))))
>>>>  TARGET_ARCH:=x86_64
>>>> -TARGET_VERSION_MIN:=10.6
>>>> +TARGET_VERSION_MIN:=10.7
>>>>
>>>>  CFLAGS:=$(CFLAGS) -DBUILD_FOR_OSX=1 \
>>>>                 -arch $(TARGET_ARCH) \
>>>> @@ -17,6 +17,7 @@
>>>>                         -fvisibility=default -fwrapv \
>>>>                         -fmacro-backtrace-limit=0
>>>> -fdiagnostics-show-note-include-stack \
>>>>                         -fmessage-length=0 -fpascal-strings
>>>> -fasm-blocks -fstrict-aliasing \
>>>> +                       -fobjc-arc \
>>>>                 -isysroot $(SDK) \
>>>>                 -include $(PLATDIR)/iOS/vm/SqueakPureObjc_Prefix.pch
>>>>
>>> [snip]
>>>
>>> _,,,^..^,,,_
>>> best, Eliot
>>>
>>>
>>
>>
>> --
>>
>> ===========================================================================
>> John M. McIntosh. Corporate Smalltalk Consulting Ltd
>> https://www.linkedin.com/in/smalltalk
>>
>> ===========================================================================
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20160506/4df47243/attachment.htm