[Vm-dev] DSAPrims broken on 64-bit VM (3684)

Nicolas Cellier nicolas.cellier.aka.nice at gmail.com
Fri May 13 20:21:37 UTC 2016


SecureHashAlgorithmTests pass here on MacOSX 64 with DSAPrims module and
<inline: #never> in #leftRotate:by:
Now it remains to fix inlining...

2016-05-13 19:31 GMT+02:00 Nicolas Cellier <
nicolas.cellier.aka.nice at gmail.com>:

> Hi Levente,
> looking at code, my wild guess (but I did not try) is that #leftRotate:by:
> is incorrectly inlined...
> The parameter should be cast to unsigned int (32 bits) otherwise extra
> bits will pollute the result.
> Unfortunately, this method get inlined with sqInt argument which are
> 64bits long in 64bits version...
> We really need to fix inlining.
> I'll try with <inline: #never> if I have time to confirm/infirm the
> guess...
>
>
>
>
> 2016-05-13 13:07 GMT+02:00 Levente Uzonyi <leves at caesar.elte.hu>:
>
>>
>> Hi All,
>>
>> As the subject says, the primitives work, but the
>> SecureHashAlgorithmTests fail, because the prims miscalculate the values. I
>> guess this is another integer type issue.
>>
>> Levente
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20160513/60c4dada/attachment.htm


More information about the Vm-dev mailing list