[Vm-dev] VM Maker: VMMaker.oscog-EstebanLorenzano.1869.mcz

[Levente Uzonyi]

On Thu, 26 May 2016, commits at source.squeak.org wrote:

>
> Esteban Lorenzano uploaded a new version of VMMaker to project VM Maker:
> http://source.squeak.org/VMMaker/VMMaker.oscog-EstebanLorenzano.1869.mcz
>
> ==================== Summary ====================
>
> Name: VMMaker.oscog-EstebanLorenzano.1869
> Author: EstebanLorenzano
> Time: 26 May 2016, 1:49:23.32419 pm
> UUID: 6ccd2249-0a2c-4279-90b4-861c39f29859
> Ancestors: VMMaker.oscog-eem.1868
>
> last change breaks cCode: '' (strings).
> this commit fixes some, but not all... I don't know what to do with this (from UnixOSProcessPlugin):
>
> self cCode: 'sigchldHandlerAction.sa_sigaction = reapChildProcess'
>
> (that dot there...)
>
>
> =============== Diff against VMMaker.oscog-eem.1868 ===============
>

snip

> Item was changed:
>  ----- Method: SoundPlugin>>primitiveSoundGetRecordingSampleRate (in category 'primitives') -----
>  primitiveSoundGetRecordingSampleRate
>  	"Return a float representing the actual sampling rate during recording. Fail if not currently recording."
>
>  	| rate |
>  	<var: #rate type: 'double '>
>  	self primitive: 'primitiveSoundGetRecordingSampleRate'.
> + 	rate := self snd_GetRecordingSampleRate.  "fail if not recording"
> - 	rate := self cCode: 'snd_GetRecordingSampleRate()'.  "fail if not recording"

Are we okay with selectors containing underscores in the VMMaker package?
If I'm not mistaken, this is the first such method.

Levente

>  	^rate asFloatObj!
>
>