[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 9b76e7: First wave of Surface x64 fixes: agree on surfaceH...

GitHub noreply at github.com
Sat Nov 12 02:55:32 UTC 2016


  Branch: refs/heads/cleanup_surfaces_for_x64
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 9b76e737fe231f3485e015324f0cd33f5e9d8fd0
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9b76e737fe231f3485e015324f0cd33f5e9d8fd0
  Author: nicolas-cellier-aka-nice <nicolas.cellier.aka.nice at gmail.com>
  Date:   2016-11-12 (Sat, 12 Nov 2016)

  Changed paths:
    M platforms/Cross/plugins/ExampleSurfacePlugin/sqMemorySurface.c
    M platforms/Cross/plugins/SqueakFFIPrims/sqManualSurface.c
    M platforms/Cross/plugins/SurfacePlugin/SurfacePlugin.c
    M platforms/Cross/plugins/SurfacePlugin/SurfacePlugin.h
    M platforms/Mac OS/plugins/QuicktimePlugin/sqMacQuicktimeInteface.c
    M platforms/Mac OS/vm/sqMacWindow.c
    M platforms/iOS/plugins/QuicktimePlugin/sqMacQuicktimeInteface.c
    M platforms/win32/plugins/B3DAcceleratorPlugin/sqWin32D3D.c

  Log Message:
  -----------
  First wave of Surface x64 fixes: agree on surfaceHandle type.

A suraceHandle will be a sqIntptr_t.
Like that it can either contain a direct pointer, or an index into some array, or anything else known to the underlying system...
And it will be compatible with LLP64.

Also, the lockSurface function will return a sqIntptr_t


  Commit: 4dae33d2dbd49701a3d213763f2128062c9973bc
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/4dae33d2dbd49701a3d213763f2128062c9973bc
  Author: nicolas-cellier-aka-nice <nicolas.cellier.aka.nice at gmail.com>
  Date:   2016-11-12 (Sat, 12 Nov 2016)

  Changed paths:
    M platforms/Cross/plugins/SurfacePlugin/SurfacePlugin.c

  Log Message:
  -----------
  Second wave of Surface x64 fixes: also fix return type of ioLockSurface


  Commit: 22385dccfa68b77119c93544f3d782f52eda5492
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/22385dccfa68b77119c93544f3d782f52eda5492
  Author: nicolas-cellier-aka-nice <nicolas.cellier.aka.nice at gmail.com>
  Date:   2016-11-12 (Sat, 12 Nov 2016)

  Changed paths:
    M platforms/Cross/plugins/SqueakFFIPrims/sqFFI.h
    M platforms/Cross/plugins/SqueakFFIPrims/sqManualSurface.c
    M platforms/Cross/plugins/SurfacePlugin/SurfacePlugin.c
    M platforms/Cross/plugins/SurfacePlugin/SurfacePlugin.h
    M platforms/Mac OS/plugins/QuicktimePlugin/sqMacQuicktimeInteface.c
    M platforms/iOS/plugins/QuicktimePlugin/sqMacQuicktimeInteface.c

  Log Message:
  -----------
  Third wave of Surface x64 fixes: agree on surfaceID,x,y,w,h,pitch,isMSB types

They were declared either long or int depending on files.
This is not 64bits compatible.
Since all those values will fit into an int, use int.


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/9b76e737fe23^...22385dccfa68


More information about the Vm-dev mailing list