[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] f39cb1: Wrestle once again with the worst code in the syst...

[GitHub]

  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: f39cb11bf2689aded27e237eea0ee992ca0e2d01
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f39cb11bf2689aded27e237eea0ee992ca0e2d01
  Author: Eliot Miranda <eliot.miranda at gmail.com>
  Date:   2016-09-02 (Fri, 02 Sep 2016)

  Changed paths:
    M platforms/iOS/vm/OSX/sqMacUnixExternalPrims.m

  Log Message:
  -----------
  Wrestle once again with the worst code in the system.  The recent fixes for
Sierra to platforms/iOS/vm/OSX/sqMacUnixExternalPrims.m broke it for bundles.
Simplify the code by splitting tryLoading into tryLoadingVariations which
handles adding optional lib prefix and .so or .dylib suffixes, and
tryLoadingBundle which constructs the full module.bundle/Contents/MacOS/module
form.  Be very careful with  stringByAppendingPathComponent: which will /not/
append a slash if given a null string to append to a path.

It would be really nice if the system didn't try and open a file some 96 times
on MacOS when trying to load a plugin.