[Vm-dev] Failing win64x64 builds - undeclared identifier 'PATH_MAX'

Ben Coman btc at openinworld.com
Sat May 13 17:30:36 UTC 2017


On Sat, May 13, 2017 at 11:28 AM, Eliot Miranda <eliot.miranda at gmail.com> wrote:
>
> Hi Ben,
>
>     can you tell me what path-related limits limits.h does define on win64?  e.g. there should be something like POSIX_PATH_MAS or XOPEN_PATH_MAX, and if neither of these is available, and nothing else looks relevant we can define a default.  I already put in a default; see platforms/Cross/plugins/B3DAcceleratorPlugin/sqOpenGLRenderer.c

I see that here https://git.io/v9QbB
and the error disappears in
https://ci.appveyor.com/project/OpenSmalltalk/vm/build/1.0.665

> But can we do better on win64/win32?

I found  _MAX_PATH in <stdlib.h>
at "Path Field Limits" for MSVC here...
https://msdn.microsoft.com/en-us/library/930f87yf.aspx

but I'm not sure how that relates to Cygwin.  I see PATH_MAX defined
in "limits.h" here...
https://cygwin.com/ml/cygwin-patches/2005-q1/msg00084.html

cheers -ben

>
> On Fri, May 12, 2017 at 9:38 AM, Ben Coman <btc at openinworld.com> wrote:
>>
>>
>> Just to note that builds...
>> * Environment: FLAVOR=squeak.stack.spur, ARCH=win64x64,
>> CYG_ROOT=C:\cygwin64, CYG_SETUP=setup-x86_64.exe, MINGW_ARCH=x86_64
>> * Environment: FLAVOR=pharo.stack.spur, ARCH=win64x64,
>> CYG_ROOT=C:\cygwin64, CYG_SETUP=setup-x86_64.exe, MINGW_ARCH=x86_64
>> are currently failing due to...
>>    ../../platforms/Cross/plugins/B3DAcceleratorPlugin/sqOpenGLRenderer.c:85:17:
>>        error: use of undeclared identifier 'PATH_MAX'
>>        char fileName[PATH_MAX+1];
>>
>> The change from imageNameSize() to PATH_MAX seems to be from 11 days ago per...
>> https://ci.appveyor.com/project/OpenSmalltalk/vm/build/1.0.637
>> "Add the B3DAcceleratorPlugin (OpenGL interface) to the 32-bit Mac build"
>>
>> Diff...
>> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/995e7aedc3b5aeb76904f92abbd8a7a1bcf8138f
>>
>> cheers -ben
>
>
>
>
> --
> _,,,^..^,,,_
> best, Eliot
>


More information about the Vm-dev mailing list