[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] VM should build with -Wall, -Wextra, -Werror (#87)

[Nicolas Cellier]

Just change the WARNINGS variable in build*/common/Makefile.flags, and inspect the generated LOGF, you'll see that we still have plenty of warnings.
Due to inlining, the same warnings are duplicated many times, but still...
Some are benign like a label was not used... Some more suspicious.
Removing them means more work on C Code Generator.

I like to work with Xcode or VisualStudio or whatever IDE for navigating in generated code and for understanding the level of danger related to these warnings, unfortunately we don't maintain such Xcode/MSVC projects, nor are we able to generate them with cmake, we don't use cmake...

Concerning undefined behavior, we have removed some UB yet, but not sure if the work is finished or not.
There are more warnings than UB (false alarms), and not all UB raise warnings
(or it would be impossible to write the most simple signed arithmetic expression, every overflow condition is UB, and potentially, anything can overflow, unless sub-expressions can be bounded).

For UB, I would strongly advise to turn on the runtime checks of clang, at least in debug mode.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/87#issuecomment-379474156
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20180407/44ffecae/attachment-0001.html>