[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

[Eliot Miranda]

Hi Vincent,  shouldn't all the
    files[0].isStdioStream = sqIsFileDescriptorATTY(0);
occurrences in platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c: sqFileStdioHandlesInto read either
    files[0].isStdioStream = sqIsFileDescriptorATTY(STD_INPUT_HANDLE);
or
    files[0].isStdioStream = sqIsFileDescriptorATTY(files[0].file);
?  Since sqIsFileDescriptorATTY could a HANDLE right?  And then you could get rid of the 
    h = (HANDLE)_get_osfhandle(fdNum);
call in sqIsFileDescriptorATTY

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/254#issuecomment-384105237
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20180424/f09ab6ad/attachment.html>