[Vm-dev] Build failed: opensmalltalk-vm 1.0.1504

[Eliot Miranda]

HI Ben,


On Thu, Dec 6, 2018 at 10:37 AM Ben Coman <btc at openinworld.com> wrote:

>
> On Fri, 7 Dec 2018 at 00:46, AppVeyor <no-reply at appveyor.com> wrote:
>
>> Build opensmalltalk-vm 1.0.1504 failed
>> <https://ci.appveyor.com/project/OpenSmalltalk/vm/builds/20822501>
>>
>> Commit 5f8620febe
>> <https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/5f8620febe> by Ben
>> Coman <btc at openInWorld.com> on 12/6/2018 4:28 PM:
>> Fix compile for Windows serial
>>
>
> This failed with....
> ../../platforms/Cross/plugins/SerialPlugin/sqNullSerialPort.c:76:14:
> error: redeclaration of 'serialPortClose' cannot add 'dllexport' attribute
> EXPORT (int) serialPortClose(int portNum) {
>
> Here are all the other definition...
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/search?q=serialPortClose&unscoped_q=serialPortClose
>
> I'm not sure which way to jump...
> * remove the EXPORT from (which might also need it removed
> from sqMacSerialPort.c.
> * push EXPORT out further into the other files
>
> Can someone advise?
>

I don't understand why the build is trying to compile
 platforms/Cross/plugins/SerialPlugin/sqNullSerialPort.c at all.  i.e.

On Mac OS X platforms/iOS/plugins/SerialPlugin/Makefile contains
"LIBSRC:=SerialPlugin.c sqUnixSerial.c", which causes only those two to be
compiled.
On Unix platforms/unix/plugins/SerialPlugin/Makefile.inc contains
"OBJS=SerialPlugin$o sqUnixSerial$o" which does the same.
On Windows... damn, I forgot to write that.  OK, give me a few...

cheers -ben
>


-- 
_,,,^..^,,,_
best, Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20181206/024438b2/attachment.html>