[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Initial revision (9c16adb)
Nicolas Cellier
notifications at github.com
Mon Dec 10 11:07:58 UTC 2018
Hmm, this is very suspiscious
../../platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c:872:8: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]
if(!pss->sockState & SOCK_BOUND_UDP) {
^ ~
../../platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c:872:8: note: add parentheses after the '!' to evaluate the bitwise operator first
if(!pss->sockState & SOCK_BOUND_UDP) {
^
( )
../../platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c:872:8: note: add parentheses around left hand side expression to silence this warning
if(!pss->sockState & SOCK_BOUND_UDP) {
^
( )
IMO it should be `if ( ! (state & flag) )` rather than `if ( (! state) & flag )`
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9c16adb9e0ac15b5a2e05ca4d090b889594c5292#commitcomment-31618047
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20181210/c2c438c4/attachment-0001.html>
More information about the Vm-dev
mailing list