[Vm-dev] Fwd: Merging FilesAttributesPlugin

[Alistair Grant]

Hi Eliot,

I've posted a new version of the FileAttributesPlugin
(FileAttributesPlugin.oscog-AlistairGrant.19):

http://smalltalkhub.com/#!/~Alistair/FileAttributesPlugin/versions/FileAttributesPlugin.oscog-AlistairGrant.19


Changes:

- Convert error values from coded values to #primitiveFailForOSError:
- #primitiveClosedir & #primitiveRewinddir return PrimErrBadArgument
  instead of a coded error for a bad argument


The updated Pharo code to use the modified plugin is in github:

https://github.com/akgrant43/FileAttributes

Would you please review the plugin code again (taking in to account the
feedback I sent in "Re: 20294 Add FileAttributesPlugin to the linux 32
bit VM", sent 6 Sep 2017).


Thanks!
Alistair



On 23 December 2017 at 19:00, Eliot Miranda <eliot.miranda at gmail.com> wrote:
>
> Hi Alistair,
>
> On Sat, Dec 23, 2017 at 9:35 AM, Alistair Grant <akgrant0710 at gmail.com> wrote:
>>
>>
>> Hi Eliot,
>>
>> I've made progress:
>>
>> - Updated FileAttributesPlugin to use #primitiveFailForOSError:.
>> - Loaded PrimitiveOSError
>> - Updated SmalltalkImage>>newSpecialObjectsArray
>> - Run SmalltalkImage current recreateSpecialObjectsArray.
>> - And triggered an error which generated the appropriate
>> PrimitiveOSError object.
>>
>> Given I've already made changes, and have a bit more tidying up to do,
>> it is probably isn't worthwhile you reviewing the code again until I
>> post an updated version.  I'll let you know when it is ready.
>
>
> OK, that's great.  Thanks and have a great holiday!
>
>>
>>
>> Merry Christmas!
>> Alistair