[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] e3fab6: Fix VMOPTION offset in Windows

[GitHub]

  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: e3fab6371ec01eed051c337baee5a584614b1e19
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/e3fab6371ec01eed051c337baee5a584614b1e19
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2018-01-03 (Wed, 03 Jan 2018)

  Changed paths:
    M platforms/win32/vm/sqWin32Main.c

  Log Message:
  -----------
  Fix VMOPTION offset in Windows

Options of the form -log:foobar.txt should not have the offset hardcoded as 5, but rather strlen(VMOPTION("log:"))

Indeed, this didn’t work in Pharo VM which used a double dash --log:foobar.txt

When the second dash will be gobbled, this won’t matter, but let’s be future proof.


  Commit: dfb100ac963c4fe757b8971e59ec2256d56b1fa2
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/dfb100ac963c4fe757b8971e59ec2256d56b1fa2
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2018-01-03 (Wed, 03 Jan 2018)

  Changed paths:
    M platforms/win32/vm/sqWin32Main.c

  Log Message:
  -----------
  Fix potential argv overflow in windows option parsing

When parsing options like -breakmnu foobar
we should check argc before gobbling the next argument...
Otherwise, we would access argv out of range.
If there is no next argument, option is invalid.


  Commit: d1916f876b1d0d8dc85165b6a69e6a8c3eba35ef
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/d1916f876b1d0d8dc85165b6a69e6a8c3eba35ef
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2018-01-03 (Wed, 03 Jan 2018)

  Changed paths:
    M platforms/win32/vm/sqWin32Main.c

  Log Message:
  -----------
  Fix broken -numextsems:4 windows VM option parsing

Previous code would try to pick the number of semaphores from next argument (if any) instead of current argument...


  Commit: 68aead299c177bf65c411e13433c79044d5d4255
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/68aead299c177bf65c411e13433c79044d5d4255
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2018-01-03 (Wed, 03 Jan 2018)

  Changed paths:
    M platforms/win32/vm/sqWin32Main.c

  Log Message:
  -----------
  Fix incorrect option gobbling in windows VM

the option following -eden:x  was incorrectly gobbled.
Same for -leakcheck:x -stackpages:x -cogmaxlit:x -cogminjump:x


  Commit: c0f6e28a1754aa0285942b536692b0e404d84e56
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c0f6e28a1754aa0285942b536692b0e404d84e56
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2018-01-03 (Wed, 03 Jan 2018)

  Changed paths:
    M platforms/win32/vm/sqWin32Main.c

  Log Message:
  -----------
  Accept both single and double dash option for windows VM

There is no more difference for PharoVM option parsing.


  Commit: 5eb7a2cb8f0ef42e39875ad8972565ee0f434b8e
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/5eb7a2cb8f0ef42e39875ad8972565ee0f434b8e
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2018-01-03 (Wed, 03 Jan 2018)

  Changed paths:
    M platforms/win32/vm/sqWin32Window.c

  Log Message:
  -----------
  Tell about possible -- usage in Windows VM


  Commit: 8b1a9886872201f016fb763d5b541acd53f8a6d2
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/8b1a9886872201f016fb763d5b541acd53f8a6d2
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2018-01-03 (Wed, 03 Jan 2018)

  Changed paths:
    M platforms/win32/vm/sqWin32Main.c
    M platforms/win32/vm/sqWin32Window.c

  Log Message:
  -----------
  Merge pull request #181 from OpenSmalltalk/Windows_VM_accept_single_or_double_dash_option

Windows vm accept single or double dash option
We can close https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/180
Build failures are unrelated (cygwin.com not responding)


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/91353618c46a...8b1a98868722