[Vm-dev] PrimitiveOSError class name

Eliot Miranda eliot.miranda at gmail.com
Mon Jan 8 15:48:39 UTC 2018


Hi Alistair,

    are you mostly using Pharo or is Squeak also interesting enough for you to want to be a trunk committer?  I think the "process" is that an existing trunk committer (in this case, me) asks on the mailing list and if no one objects an admin adds you via the repository web interface.

_,,,^..^,,,_ (phone)

> On Jan 7, 2018, at 11:18 PM, Alistair Grant <akgrant0710 at gmail.com> wrote:
> 
> 
> Hi Eliot,
> 
>> On 7 January 2018 at 18:41, Eliot Miranda <eliot.miranda at gmail.com> wrote:
>> 
>> 
>> 
>>> On Jan 7, 2018, at 1:49 AM, Alistair Grant <akgrant0710 at gmail.com> wrote:
>>> 
>>> 
>>> Hi Eliot,
>>> 
>>> I'm just preparing a fogbugz issue and PR to add PrimitiveOSError to
>>> Pharo and was wondering about the class name.
>>> 
>>> As you say in the class comments, errorName is typically set to
>>> #'operating system error' (I haven't seen anything else), which makes
>>> the class name and errorName somewhat redundant.
>>> 
>>> What do you think of renaming the class to PrimitiveError, which will
>>> make it a bit more general and extensible in future?
>> 
>> I have no objection.  Will you make it so in trunk?  If so, please do.
> 
> Sure.  I've updated both my Pharo and Squeak development images.  All
> the tests pass in Pharo.  There two failures in Squeak that I want to
> make sure aren't related.
> 
> Cheers,
> Alistair


More information about the Vm-dev mailing list