[Vm-dev] VMProfileLinuxSupportPlugin causes Linux builds to fail

[Tobias Pape]

welcome :)

> On 17.06.2018, at 19:24, Alistair Grant <akgrant0710 at gmail.com> wrote:
> 
> 
> On Sat, 16 Jun 2018 at 21:06, Tobias Pape <Das.Linux at gmx.de> wrote:
>> 
>> 
>> 
>>> On 16.06.2018, at 20:06, Eliot Miranda <eliot.miranda at gmail.com> wrote:
>>> 
>>> Hi Tobias, Hi Alistair,
>>> 
>>> On Sat, Jun 16, 2018 at 11:02 AM, Eliot Miranda <eliot.miranda at gmail.com> wrote:
>>> Hi Alistair, Hi Tobias,
>>> 
>>> On Sat, Jun 16, 2018 at 7:05 AM, Alistair Grant <akgrant0710 at gmail.com> wrote:
>>> 
>>> Hi Eliot and Everyone,
>>> 
>>> Travis builds are failing due to compilation errors in
>>> VMProfileLinuxSupportPlugin.  See e.g.
>>> https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/393065793
>>> 
>>> The most recent change to the file was in VMMaker.oscog-eem.2394 on 30 May 2018.
>>> 
>>> Reverting VMProfileLinuxSupportPlugin.c to the previous version from
>>> VMMaker.oscog-eem.2347 dated 8 March 2018 avoids the compilation
>>> problems.
>>> 
>>> Doing a diff of the two files gives:
>>> 
>>> 2c2
>>> < VMPluginCodeGenerator VMMaker.oscog-eem.2394 uuid:
>>> 61ae96f8-fd2b-4208-87ff-cf1cd6b3f859
>>> ---
>>>> VMPluginCodeGenerator VMMaker.oscog-eem.2347 uuid: 062614a7-e3da-4b30-997a-9568911b9ff5
>>> 4c4
>>> < VMProfileLinuxSupportPlugin VMMaker.oscog-eem.2394 uuid:
>>> 61ae96f8-fd2b-4208-87ff-cf1cd6b3f859
>>> ---
>>>> VMProfileLinuxSupportPlugin VMMaker.oscog-eem.2347 uuid: 062614a7-e3da-4b30-997a-9568911b9ff5
>>> 6c6
>>> < static char __buildInfo[] = "VMProfileLinuxSupportPlugin
>>> VMMaker.oscog-eem.2394 uuid: 61ae96f8-fd2b-4208-87ff-cf1cd6b3f859 "
>>> __DATE__ ;
>>> ---
>>>> static char __buildInfo[] = "VMProfileLinuxSupportPlugin VMMaker.oscog-eem.2347 uuid: 062614a7-e3da-4b30-997a-9568911b9ff5 " __DATE__ ;
>>> 17,18c17,18
>>> < #if defined(HAVE_DLFCN_H)
>>> < # include <dlfcn.h>
>>> ---
>>>> #ifdef __OpenBSD__
>>>> #include <dlfcn.h>
>>> 19a20,23
>>>> #ifndef _GNU_SOURCE
>>>> # define _GNU_SOURCE
>>>> #endif
>>>> #include <link.h>
>>> 104c108
>>> < "VMProfileLinuxSupportPlugin VMMaker.oscog-eem.2394 (i)"
>>> ---
>>>> "VMProfileLinuxSupportPlugin VMMaker.oscog-eem.2347 (i)"
>>> 106c110
>>> < "VMProfileLinuxSupportPlugin VMMaker.oscog-eem.2394 (e)"
>>> ---
>>>> "VMProfileLinuxSupportPlugin VMMaker.oscog-eem.2347 (e)"
>>> 
>>> Any suggestions?
>>> 
>>> Tobias, I believe that your changes on May 18th, VMMaker.oscog-topa.2385 & VMMaker.oscog-topa.2386 are related.  Any suggestions?
>>> 
>>> Indeed, Tobias, it's your bug ;-)  :
>> 
>> It turns out that the include of <link.h> got missing. I overlooked it as it was on the same line as the GNU_SOURCE check:
>> 
>> addHeaderFile: '#ifndef _GNU_SOURCE\# define _GNU_SOURCE\#endif\#include <link.h>' withCRs;
>> 
>> 
>> fixed in VMMaker.oscog-topa.2418.
> 
> Thanks, Tobias!
> 
> Cheers,
> Alistair