[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] macos: Fix --trace for the PharoVM (#231)
Holger Freyther
notifications at github.com
Sun Mar 25 14:17:55 UTC 2018
zecke commented on this pull request.
> @@ -166,7 +168,7 @@ - (int) parseArgument: (NSString *) argData peek: (char *) peek
/* Options with no arguments */
NS_DURING;
- if ([argData compare: VMOPTIONOBJ("psn_") options: NSLiteralSearch range: NSMakeRange(0,5)] == NSOrderedSame) {
+ if ([argData compare: VMOPTIONOBJ("psn_") options: NSLiteralSearch range: NSMakeRange(0,VMOPTIONLEN(5))] == NSOrderedSame) {
Good point. OSX doesn't care about the number of dashes we have. I don't like the code. We should strip the dashes before parsing the arguments but that would have been a bigger change and outside the timebox I had. :(
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/231#discussion_r176941835
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20180325/fafcb371/attachment.html>
More information about the Vm-dev
mailing list